You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/06/19 06:50:54 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new pull request, #188: Fix low hanging fruit from warnings
mdedetrich opened a new pull request, #188:
URL: https://github.com/apache/incubator-pekko-http/pull/188
Low hanging fruit safe to apply fixes from scalac warnings from various Scala versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich merged pull request #188: Fix low hanging fruit from warnings
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #188:
URL: https://github.com/apache/incubator-pekko-http/pull/188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #188: Fix low hanging fruit from warnings
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #188:
URL: https://github.com/apache/incubator-pekko-http/pull/188#discussion_r1233618277
##########
http/src/main/scala/org/apache/pekko/http/javadsl/unmarshalling/Unmarshaller.scala:
##########
@@ -119,7 +119,7 @@ object Unmarshaller extends pekko.http.javadsl.unmarshalling.Unmarshallers {
unmarshalling.Unmarshaller.firstOf(u1.asScala, u2.asScala, u3.asScala, u4.asScala, u5.asScala)
}
- @nowarn("msg=parameter value mi in method adaptInputToJava is never used")
+ @nowarn("msg=mi in method adaptInputToJava is never used")
Review Comment:
The warning is slightly different depending on the Scala version, i.e. on one version its `parameter value mi in method adaptInputToJava is never used` and on another its `parameter mi in method adaptInputToJava is never used` so this will correctly supress the warnings on all versions of Scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #188: Fix low hanging fruit from warnings
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #188:
URL: https://github.com/apache/incubator-pekko-http/pull/188#discussion_r1233618277
##########
http/src/main/scala/org/apache/pekko/http/javadsl/unmarshalling/Unmarshaller.scala:
##########
@@ -119,7 +119,7 @@ object Unmarshaller extends pekko.http.javadsl.unmarshalling.Unmarshallers {
unmarshalling.Unmarshaller.firstOf(u1.asScala, u2.asScala, u3.asScala, u4.asScala, u5.asScala)
}
- @nowarn("msg=parameter value mi in method adaptInputToJava is never used")
+ @nowarn("msg=mi in method adaptInputToJava is never used")
Review Comment:
The warning is slightly different depending on the Scala version, i.e. on one version its `parameter value mi in method adaptInputToJava is never used` and on another its `parameter mi in method adaptInputToJava is never used` so this will correctly suppress the warnings on all versions of Scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org