You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/07/25 10:27:11 UTC
[GitHub] [fineract] logoutdhaval opened a new pull request, #2454: Fineract 1668 latest
logoutdhaval opened a new pull request, #2454:
URL: https://github.com/apache/fineract/pull/2454
## Description
[Fineract-1668](https://issues.apache.org/jira/browse/FINERACT-1668).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] logoutdhaval closed pull request #2454: Fineract 1668 latest
Posted by GitBox <gi...@apache.org>.
logoutdhaval closed pull request #2454: Fineract 1668 latest
URL: https://github.com/apache/fineract/pull/2454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] logoutdhaval commented on a diff in pull request #2454: Fineract 1668 latest
Posted by GitBox <gi...@apache.org>.
logoutdhaval commented on code in PR #2454:
URL: https://github.com/apache/fineract/pull/2454#discussion_r934671431
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java:
##########
@@ -444,4 +444,11 @@ public boolean isBusinessDateEnabled() {
public boolean isCOBDateAdjustmentEnabled() {
return getGlobalConfigurationPropertyData(ENABLE_AUTOMATIC_COB_DATE_ADJUSTMENT).isEnabled();
}
+
+ @Override
+ public boolean isReversalTransactionAllowed() {
+ final String propertyName = "allow-reversals-for-reversed-transactions";
Review Comment:
I changed configuration name to `enable-post-reversal-txns-for-reverse-transactions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2454: Fineract 1668 latest
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2454:
URL: https://github.com/apache/fineract/pull/2454#discussion_r932068612
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java:
##########
@@ -444,4 +444,11 @@ public boolean isBusinessDateEnabled() {
public boolean isCOBDateAdjustmentEnabled() {
return getGlobalConfigurationPropertyData(ENABLE_AUTOMATIC_COB_DATE_ADJUSTMENT).isEnabled();
}
+
+ @Override
+ public boolean isReversalTransactionAllowed() {
+ final String propertyName = "allow-reversals-for-reversed-transactions";
Review Comment:
This configuration is misleadingly named. As far as I can see, you touched FixedDepositAccounts, RecurringDepositAccount and SavingsAccounts.
Please name the config accordingly cause judging by its name it should also configure all other type of accounts, for example Loan accounts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj merged pull request #2454: Fineract 1668 latest
Posted by GitBox <gi...@apache.org>.
fynmanoj merged PR #2454:
URL: https://github.com/apache/fineract/pull/2454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org