You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/01 18:26:15 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #462: [FLINK-30266] Roll back change to HA metadata check logic
gyfora opened a new pull request, #462:
URL: https://github.com/apache/flink-kubernetes-operator/pull/462
## What is the purpose of the change
Revert an "improvement" to the HA metadata checking logic that actually only causes problems. In this case it did not allow jobs to recover without checkpoints in last-state mode.
## Brief change log
revert change
## Verifying this change
manually verified
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #462: [FLINK-30266] Roll back change to HA metadata check logic
Posted by GitBox <gi...@apache.org>.
mxm commented on code in PR #462:
URL: https://github.com/apache/flink-kubernetes-operator/pull/462#discussion_r1037962140
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -147,12 +148,7 @@ public static boolean isHaMetadataAvailable(
.list()
.getItems();
- return configMaps.stream()
- .anyMatch(
- map ->
- !map.isMarkedForDeletion()
- && map.getData() != null
- && !map.getData().isEmpty());
+ return configMaps.stream().anyMatch(Predicate.not(ConfigMap::isMarkedForDeletion));
Review Comment:
In case somebody wonders, this change was included in 45a280aa2d6824ded3a03b503dc33208f159f5d9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #462: [FLINK-30266] Roll back change to HA metadata check logic
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #462:
URL: https://github.com/apache/flink-kubernetes-operator/pull/462#issuecomment-1335270825
Closing in favor of #465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi closed pull request #462: [FLINK-30266] Roll back change to HA metadata check logic
Posted by GitBox <gi...@apache.org>.
mbalassi closed pull request #462: [FLINK-30266] Roll back change to HA metadata check logic
URL: https://github.com/apache/flink-kubernetes-operator/pull/462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org