[GitHub] [skywalking] kezhenxu94 commented on issue #3658: Make agent plugin tests in PR only necessary.

[GitBox <gi...@apache.org>]

kezhenxu94 commented on issue #3658: Make agent plugin tests in PR only necessary.
URL: https://github.com/apache/skywalking/issues/3658#issuecomment-545491380
 
 
   to track this task, we have several sub-tasks here:
   
   - [x] submodule changes should trigger build if related
   - [x] list the changed file sets to trigger/skip E2E, CI, Agent Test
   - [ ] comment on PR when skipped
   
   this is technically feasible, we can access the asf-git credential in Jenkins job (although just read access to this repo, but it's obviously enough to comment),
   
   the difficulty is there may be multiple jobs skipped, say E2E, Agent-Test-Workload 1~3, and we just want only one comment here, avoiding flooding the timeline of pull request, but it's a **nice to have** feature, I'll try to bring the comment here, and later to optimize it (one comment)
   
   - [ ] support manually trigger build job forcibly, in case that the condition failed to detect
   
   this is the most time-waste sub-task here, after struggling nearly a whole day, it turns out that, jobs triggered by comment on PR is not different from that are triggered by push events, there is no something like `triggeredByUserId`
   
   A possible workaround is to compare the current job with the previous job, if the two commit id is the same, meaning one commit is triggered more than one time (one of which is triggered manually), then build it forcibly.
   
   Will try to do task 3 and task 4 soon if there is no bug in design above, need some review on the thought above, especially task 4 @wu-sheng 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services