You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/06 07:20:04 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #218: sethost: If
no host options are specified, try to guess
yamt opened a new pull request #218: sethost: If no host options are specified, try to guess
URL: https://github.com/apache/incubator-nuttx/pull/218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #218:
sethost: If no host options are specified, try to guess
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #218: sethost: If no host options are specified, try to guess
URL: https://github.com/apache/incubator-nuttx/pull/218#discussion_r375739459
##########
File path: tools/sethost.sh
##########
@@ -94,6 +94,19 @@ while [ ! -z "$1" ]; do
shift
done
+# If the host was not explicitly given, try to guess.
+if [ -z "$host" ]; then
+ case $(uname -s) in
+ Darwin)
+ host=macos
+ ;;
+ *)
Review comment:
thank you for info. done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #218: sethost: If no host options are specified, try to guess
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #218: sethost: If no host options are specified, try to guess
URL: https://github.com/apache/incubator-nuttx/pull/218#discussion_r375698399
##########
File path: tools/sethost.sh
##########
@@ -94,6 +94,19 @@ while [ ! -z "$1" ]; do
shift
done
+# If the host was not explicitly given, try to guess.
+if [ -z "$host" ]; then
+ case $(uname -s) in
+ Darwin)
+ host=macos
+ ;;
+ *)
Review comment:
Let's do more check here?
Here is uname -s output:
Cygwin: CYGWIN_NT-10.0-WOW
Linux: Linux
MSYS: MINGW32_NT-6.2
We can use prefix to determine all option
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #218: sethost: If no host options are specified, try to guess
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #218: sethost: If no host options are specified, try to guess
URL: https://github.com/apache/incubator-nuttx/pull/218#discussion_r375698654
##########
File path: tools/sethost.sh
##########
@@ -34,7 +34,7 @@
progname=$0
debug=n
-host=linux
+host=
wenv=cygwin
Review comment:
wenv=
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #218:
sethost: If no host options are specified, try to guess
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #218: sethost: If no host options are specified, try to guess
URL: https://github.com/apache/incubator-nuttx/pull/218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services