You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by gyfora <gi...@git.apache.org> on 2014/07/17 13:15:00 UTC

[GitHub] incubator-flink pull request: [FLINK-629] getFieldNotNull added to...

GitHub user gyfora opened a pull request:

    https://github.com/apache/incubator-flink/pull/73

    [FLINK-629] getFieldNotNull added to Tuple and updated operators

    Operators which use key comparisons now use getFieldNotNull for getting the key fields, which will throw NullKeyFieldException if the key is null. Aggregators are also updated to use getFieldNotNull and will throw a NullFieldExceptions if the field is null.
    
    The TupleSerializer now throws NullFieldException when it encounters a null field it cannot serialize instead of a NullPointerException.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gyfora/incubator-flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit e5cc6a4724ebfeac4dcef8faffe1cbe3c0dcacf0
Author: gyfora <gy...@gmail.com>
Date:   2014-07-16T17:09:04Z

    [FLINK-629] getFieldNotNull added to Tuple and updated Aggregators and Comparators to use that where appropriate

commit 337dd967528d6cf65d317561d4aa0cd38edb70b7
Author: mbalassi <ba...@gmail.com>
Date:   2014-07-17T07:49:53Z

    [FLINK-629] Updated getFieldNotNull usage and added it to TupleSerializers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: [FLINK-629] getFieldNotNull added to...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:

    https://github.com/apache/incubator-flink/pull/73#issuecomment-54731414
  
    I merged this PR.
    @gyfora @mbalassi Thanks guys!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: [FLINK-629] getFieldNotNull added to...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---