RE: clover and cpd plugin clashes

[Vincent Massol <vm...@pivolis.com>]

> -----Original Message-----
> From: Mike Perham [mailto:Mike.Perham@webifysolutions.com]
> Sent: mardi 30 mai 2006 17:56
> To: Vincent Massol
> Subject: RE: clover and cpd plugin clashes
> 
> I would argue that the modified Clover code should not be reported on at
> all.  

Agreed

> You wouldn't want  JXR, javancss, etc to report on that source
> because it does not actually reflect the code in your module.  That's how
> I arrived at my conclusion.

We agree on this.
 
> Can you give me an example of the workaround you are suggesting?

I was just saying that you should not run the checks inside the custom
lifecycle spawned by the clover plugin.

The Clover plugin generates instrumented code and database data during the
execution of the clover:instrument goal. Put the execution of this goal
inside an <execution> and do all your checks in another execution..

Now I do agree that m2 needs a better way of doing this and I think I've
already raised some jira on this (I'm too lazy to search for it right now).
One solution is to have the same mechanism for reporting plugins than we
have for build plugins and thus have the ability to have executions there
too.

Let's continue this discussion on the maven list.

Thanks
-Vincent

> -----Original Message-----
> >
> > So this is an interesting bug.
> >
> > I have clover and pmd:cpd-check configured.  Clover injects a block of
> > source into every source file for instrumentation purposes.  cpd sees
> > this block of code as copy/pasted code because it occurs in every
> > source file and fails my build.
> >
> > Who's in the wrong here?  I'm inclined to say it's a Clover plugin bug
> > because it should not be exposing its modified code as source to be
> > examined by other plugins.
> 
> Maybe the faulty is CPD because it should accept to ignore some specified
> blocks of code? :-)
> 
> What we should do is disable the CPD check in the custom lifecycle spawned
> by the clover plugin. Why don't you simply remote the cpd-check from your
> clover <execution>?
> 
> -Vincent
> 
> 
> 
> 
> 
> 
> __________________________________________________________________________
> _
> Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son
> interface révolutionnaire.
> http://fr.mail.yahoo.com


	

	
		
___________________________________________________________________________ 
Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire.
http://fr.mail.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org