You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Tobiichi-Origam1 (via GitHub)" <gi...@apache.org> on 2024/10/23 10:59:47 UTC
[PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Tobiichi-Origam1 opened a new pull request, #42344:
URL: https://github.com/apache/doris/pull/42344
## Proposed changes
Issue Number: close #40835
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1839348979
##########
build.sh:
##########
@@ -551,8 +551,8 @@ FE_MODULES="$(
# Clean and build Backend
if [[ "${BUILD_BE}" -eq 1 ]]; then
- update_submodule "be/src/apache-orc" "apache-orc" "https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.tar.gz"
- update_submodule "be/src/clucene" "clucene" "https://github.com/apache/doris-thirdparty/archive/refs/heads/clucene.tar.gz"
+ # update_submodule "be/src/apache-orc" "apache-orc" "https://github.com/apache/doris-thirdparty/archive/ads/clucene.tarefs/heads/orc.tar.gz"
Review Comment:
don't commit this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2517976303
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "Tobiichi-Origam1 (via GitHub)" <gi...@apache.org>.
Tobiichi-Origam1 commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1852767682
##########
be/src/olap/comparison_predicate.h:
##########
@@ -524,7 +526,7 @@ class ComparisonPredicateBase : public ColumnPredicate {
_base_loop_bit<is_nullable, is_and>(sel, size, flags, null_map, data_array,
dict_code);
} else {
- LOG(FATAL) << "column_dictionary must use StringRef predicate.";
+ static_assert(!std::is_same_v<T, StringRef>, "column_dictionary must use StringRef predicate.");
Review Comment:
sorry I made a mistake here, and I have done fixing three similar errors in this file right away
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2547766321
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863192371
##########
be/src/olap/in_list_predicate.h:
##########
@@ -431,8 +431,8 @@ class InListPredicateBase : public ColumnPredicate {
}
}
} else {
- LOG(FATAL) << "column_dictionary must use StringRef predicate.";
- __builtin_unreachable();
+ throw Exception(
Review Comment:
use `static_assert`. or just not modify this in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1814335826
##########
be/src/vec/functions/function_cast.h:
##########
@@ -651,7 +651,7 @@ struct ConvertImplNumberToJsonb {
} else if constexpr (std::is_same_v<ColumnFloat64, ColumnType>) {
writer.writeDouble(data[i]);
} else {
- LOG(FATAL) << "unsupported type ";
+ throw Exception(Status::NotSupported("unsupported type "));
Review Comment:
for `if constexpr`, you can use `static_assert` rather than `throw`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2548934090
TeamCity be ut coverage result:
Function Coverage: 38.87% (10129/26061)
Line Coverage: 29.78% (85138/285905)
Region Coverage: 28.88% (43419/150344)
Branch Coverage: 25.40% (22124/87104)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ac1d12e062d3d12ecf38fb94920d748485f03083_ac1d12e062d3d12ecf38fb94920d748485f03083/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2530254749
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2539001971
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1865210378
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -3433,8 +3433,7 @@ void DateV2Value<T>::unchecked_set_time(uint8_t hour, uint8_t minute, uint8_t se
date_v2_value_.second_ = second;
date_v2_value_.microsecond_ = microsecond;
} else {
- LOG(FATAL) << "Invalid operation 'set_time' for date!";
- __builtin_unreachable();
+ throw Exception(Status::FatalError("Invalid operation 'set_time' for date!"));
Review Comment:
you can just add `requires is_datetime` for this function declare and definition and remove the `if-else`
##########
be/src/util/jni-util.cpp:
##########
@@ -241,7 +242,8 @@ void JniUtil::parse_max_heap_memory_size_from_jvm(JNIEnv* env) {
}
}
if (0 == max_jvm_heap_memory_size_) {
- LOG(FATAL) << "the max_jvm_heap_memory_size_ is " << max_jvm_heap_memory_size_;
+ throw Exception(Status::FatalError("the max_jvm_heap_memory_size_ is {}",
Review Comment:
dont change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2431736408
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1814348216
##########
be/src/common/elf.cpp:
##########
@@ -40,21 +41,22 @@ Elf::Elf(const std::string& path) {
std::error_code ec;
elf_size = std::filesystem::file_size(_file, ec);
if (ec) {
- LOG(FATAL) << fmt::format("failed to get file size {}: ({}), {}", _file.native(),
- ec.value(), ec.message());
+ throw Exception(Status::IOError("failed to get file size {}: ({}), {}", _file.native(),
Review Comment:
please add a new error type. we can call it `FatalError`. and for all Exception changed from `LOG(FATAL)`, use it as the error code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #42344:
URL: https://github.com/apache/doris/pull/42344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2550196245
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1868815212
##########
be/src/vec/common/assert_cast.h:
##########
@@ -45,33 +45,33 @@ PURE To assert_cast(From&& from) {
if (auto ptr = dynamic_cast<To>(from); ptr != nullptr) {
return ptr;
}
- LOG(FATAL) << fmt::format("Bad cast from type:{}* to {}",
- demangle(typeid(*from).name()),
- demangle(typeid(To).name()));
+ throw doris::Exception(doris::Status::FatalError("Bad cast from type:{}* to {}",
+ demangle(typeid(*from).name()),
+ demangle(typeid(To).name())));
}
} else {
if (typeid(from) == typeid(To)) {
return static_cast<To>(from);
}
}
- LOG(FATAL) << fmt::format("Bad cast from type:{} to {}", demangle(typeid(from).name()),
- demangle(typeid(To).name()));
- __builtin_unreachable();
+ throw doris::Exception(doris::Status::FatalError("Bad cast from type:{} to {}",
+ demangle(typeid(from).name()),
+ demangle(typeid(To).name())));
};
#ifndef NDEBUG
try {
return perform_cast(std::forward<From>(from));
} catch (const std::exception& e) {
- LOG(FATAL) << "assert cast err:" << e.what();
+ throw doris::Exception(doris::Status::FatalError("assert cast err:{}", e.what()));
}
__builtin_unreachable();
Review Comment:
remove these two `__builtin_unreachable`, include L76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2539674879
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2431757165
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2471004079
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11801561622") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 297:
local submodule_path=$1
^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 298:
local submodule_name=$2
^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 299:
local archive_url=$3
^------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 301:
set +e
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 302:
cd "${DORIS_HOME}"
^----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 303:
echo "Update ${submodule_name} submodule ..."
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 304:
git submodule update --init --recursive "${submodule_path}"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 305:
exit_code=$?
^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 306:
if [[ "${exit_code}" -eq 0 ]]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 307:
cd "${submodule_path}"
^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 308:
submodule_commit_id=$(git rev-parse HEAD)
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 309:
cd -
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 310:
expect_submodule_commit_id=$(git ls-tree HEAD "${submodule_path}" | awk '{print $3}')
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 311:
echo "Current commit ID of ${submodule_name} submodule: ${submodule_commit_id}, expected is ${expect_submodule_commit_id}"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 313:
set -e
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 314:
if [[ "${exit_code}" -ne 0 ]]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 315:
set +e
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 317:
submodule_commit=$(git ls-tree HEAD "${submodule_path}" | awk '{print $3}')
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 318:
exit_code=$?
^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 319:
if [[ "${exit_code}" = "0" ]]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 320:
commit_specific_url=$(echo "${archive_url}" | sed "s/refs\/heads/${submodule_commit}/")
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 322:
commit_specific_url="${archive_url}"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 324:
set -e
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 325:
echo "Update ${submodule_name} submodule failed, start to download and extract ${commit_specific_url}"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 327:
mkdir -p "${DORIS_HOME}/${submodule_path}"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 328:
curl -L "${commit_specific_url}" | tar -xz -C "${DORIS_HOME}/${submodule_path}" --strip-components=1
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
For more information:
https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2552685132
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2540298125
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2548613027
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2547784465
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1855405905
##########
be/src/gutil/port.h:
##########
@@ -780,7 +780,7 @@ typedef int ssize_t;
using std::ostream;
inline ostream& operator<<(ostream& os, const unsigned __int64& num) {
// Fake operator; doesn't actually do anything.
- LOG(FATAL) << "64-bit ostream operator << not supported in VC++ 6";
+ throw Exception(Statsu::FatalError("64-bit ostream operator << not supported in VC++ 6"));
Review Comment:
here's a typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1855405986
##########
be/src/gutil/strings/escaping.cc:
##########
@@ -899,8 +902,7 @@ int Base64UnescapeInternal(const char* src, int szsrc, char* dest, int szdest,
// of data bytes that must remain in the input to avoid aborting the
// loop.
#define GET_INPUT(label, remain) \
- label: \
- --szsrc; \
+ label : --szsrc; \
Review Comment:
dont re-format it if you didn't change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1855406295
##########
be/src/common/exception.cpp:
##########
@@ -29,7 +29,8 @@ Exception::Exception(int code, const std::string_view& msg) {
_err_msg->_stack = get_stack_trace();
}
if (config::exit_on_exception) {
- LOG(FATAL) << "[ExitOnException] error code: " << code << ", message: " << msg;
+ throw Exception(
Review Comment:
dont change this. we want always exit on exception here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863190834
##########
be/src/gutil/strings/util.cc:
##########
@@ -489,7 +491,7 @@ const char* strstr_delimited(const char* haystack, const char* needle, char deli
++haystack;
}
}
- LOG(FATAL) << "Unreachable statement";
+ throw doris::Exception(doris::Status::FatalError("Unreachable statement"));
return nullptr;
Review Comment:
remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2538725464
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1868813940
##########
be/src/vec/exec/format/parquet/decoder.h:
##########
@@ -79,7 +79,8 @@ class Decoder {
}
virtual MutableColumnPtr convert_dict_column_to_string_column(const ColumnInt32* dict_column) {
- LOG(FATAL) << "Method convert_dict_column_to_string_column is not supported";
+ throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
+ "Method convert_dict_column_to_string_column is not supported");
__builtin_unreachable();
Review Comment:
remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2530274075
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2539675916
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2550444182
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2540297439
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863197534
##########
be/src/vec/data_types/data_type_quantilestate.h:
##########
@@ -94,9 +94,7 @@ class DataTypeQuantileState : public IDataType {
Field get_default() const override { return QuantileState(); }
[[noreturn]] Field get_field(const TExprNode& node) const override {
- throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
- "Unimplemented get_field for quantile state");
- __builtin_unreachable();
+ throw Exception(Status::FatalError("Unimplemented get_field for quantile state"));
Review Comment:
do not change this
##########
be/src/vec/data_types/data_type_object.h:
##########
@@ -87,7 +87,7 @@ class DataTypeObject : public IDataType {
}
std::stringstream error_string;
node.printTo(error_string);
- throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Unkown literal {}", error_string.str());
+ throw Exception(Status::FatalError("Unkown literal {}", error_string.str()));
Review Comment:
why change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863198314
##########
be/src/vec/functions/function_binary_arithmetic.h:
##########
@@ -423,8 +423,8 @@ struct DecimalBinaryOperation {
if constexpr (check_overflow && !is_to_null_type &&
((!OpTraits::is_multiply && !OpTraits::is_plus_minus))) {
- throw doris::Exception(ErrorCode::INTERNAL_ERROR,
- "adapt_decimal_constant_constant Invalid function type!");
+ throw Exception(
Review Comment:
do not change internal error to fatal error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1865207309
##########
be/src/util/expected.hpp:
##########
Review Comment:
dont change this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863794472
##########
be/test/testutil/test_util.cpp:
##########
Review Comment:
dont change this file
##########
be/src/olap/tablet_meta.cpp:
##########
Review Comment:
dont change this file cuz it may lead to wrong data storage
##########
cloud/src/common/network_util.cpp:
##########
Review Comment:
dont change this file
##########
be/src/olap/tablet.cpp:
##########
Review Comment:
dont change this file cuz it may lead to wrong data storage
##########
be/src/olap/storage_engine.cpp:
##########
Review Comment:
dont change this file cuz it may lead to wrong data storage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2548632501
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1851557930
##########
be/src/gutil/strings/numbers.cc:
##########
@@ -10,15 +10,18 @@
#include <ctype.h>
#include <errno.h>
#include <float.h> // for DBL_DIG and FLT_DIG
-#include <math.h> // for HUGE_VAL
+#include <inttypes.h>
+#include <math.h> // for HUGE_VAL
Review Comment:
warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
```suggestion
#include <cmath> // for HUGE_VAL
```
##########
be/src/gutil/strings/numbers.cc:
##########
@@ -10,15 +10,18 @@
#include <ctype.h>
#include <errno.h>
#include <float.h> // for DBL_DIG and FLT_DIG
-#include <math.h> // for HUGE_VAL
+#include <inttypes.h>
Review Comment:
warning: inclusion of deprecated C++ header 'inttypes.h'; consider using 'cinttypes' instead [modernize-deprecated-headers]
```suggestion
#include <cinttypes>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1852664085
##########
be/src/olap/comparison_predicate.h:
##########
@@ -524,7 +526,7 @@ class ComparisonPredicateBase : public ColumnPredicate {
_base_loop_bit<is_nullable, is_and>(sel, size, flags, null_map, data_array,
dict_code);
} else {
- LOG(FATAL) << "column_dictionary must use StringRef predicate.";
+ static_assert(!std::is_same_v<T, StringRef>, "column_dictionary must use StringRef predicate.");
Review Comment:
we wrote `if constexpr (std::is_same_v<T, StringRef>)` upon
so here going into `else` means `T` is **not same** with `StringRef`. we want a failure here. so I think we should assert `std::is_same_v<T, StringRef>`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2538987545
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2538726606
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2550530461
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863192822
##########
be/src/olap/key_coder.h:
##########
@@ -300,7 +300,7 @@ class KeyCoderTraits<FieldType::OLAP_FIELD_TYPE_CHAR> {
}
static Status decode_ascending(Slice* encoded_key, size_t index_size, uint8_t* cell_ptr) {
- LOG(FATAL) << "decode_ascending is not implemented";
+ throw Exception(Status::FatalError("decode_ascending is not implemented"));
return Status::OK();
Review Comment:
remove the `return`s
##########
be/src/olap/memtable.cpp:
##########
@@ -28,6 +28,7 @@
#include "bvar/bvar.h"
#include "common/config.h"
+#include "common/exception.h"
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863787324
##########
be/src/pipeline/exec/operator.cpp:
##########
@@ -398,8 +398,7 @@ std::shared_ptr<BasicSharedState> DataSinkOperatorX<LocalStateType>::create_shar
return nullptr;
} else if constexpr (std::is_same_v<typename LocalStateType::SharedStateType,
MultiCastSharedState>) {
- LOG(FATAL) << "should not reach here!";
- return nullptr;
+ throw Exception(Status::FatalError("should not reach here!"));
Review Comment:
try use `static_assert` for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2516495609
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1867503443
##########
be/src/service/backend_options.cpp:
##########
Review Comment:
dont change this file
##########
be/src/vec/exec/format/parquet/decoder.h:
##########
@@ -79,8 +79,8 @@ class Decoder {
}
virtual MutableColumnPtr convert_dict_column_to_string_column(const ColumnInt32* dict_column) {
- LOG(FATAL) << "Method convert_dict_column_to_string_column is not supported";
- __builtin_unreachable();
+ throw Exception(
Review Comment:
use NOT_IMP for this
##########
be/src/vec/olap/olap_data_convertor.h:
##########
@@ -455,8 +455,8 @@ class OlapBlockDataConvertor {
const void* get_data() const override { return _results.data(); };
const void* get_data_at(size_t offset) const override {
- LOG(FATAL) << "now not support get_data_at for OlapColumnDataConvertorArray";
- __builtin_unreachable();
+ throw Exception(Status::FatalError(
Review Comment:
use NOT_IMP for them
##########
be/src/vec/data_types/data_type_nothing.cpp:
##########
Review Comment:
dont change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Log) Reduce usage of log fatal(PART I) [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2516666161
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org