[GitHub] [spark] LuciferYang commented on a diff in pull request #37379: [SPARK-39951][SQL] Update Parquet V2 columnar check for nested fields

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #37379:
URL: https://github.com/apache/spark/pull/37379#discussion_r935685218


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala:
##########
@@ -72,6 +73,8 @@ case class ParquetPartitionReaderFactory(
   private val enableOffHeapColumnVector = sqlConf.offHeapColumnVectorEnabled
   private val enableVectorizedReader: Boolean =
     ParquetUtils.isBatchReadSupportedForSchema(sqlConf, resultSchema)
+  private val supportsColumnar = enableVectorizedReader && sqlConf.wholeStageEnabled &&

Review Comment:
   https://github.com/apache/spark/blob/222cb80227fb9c24b1677c5a746c0a174a18b537/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala#L168-L173
   
   Should we also remove `conf.parquetVectorizedReaderEnabled` from `ParquetFileFormat#supportBatch`? `ParquetUtils.isBatchReadSupportedForSchema` contains this condition
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org