You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/09/07 04:34:39 UTC

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to transp...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17899#discussion_r215843736
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -726,14 +726,36 @@ object CollapseRepartition extends Rule[LogicalPlan] {
     object CollapseWindow extends Rule[LogicalPlan] {
       def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
         case w1 @ Window(we1, ps1, os1, w2 @ Window(we2, ps2, os2, grandChild))
    -        if ps1 == ps2 && os1 == os2 && w1.references.intersect(w2.windowOutputSet).isEmpty &&
    --- End diff --
    
    I wouldn't include style changes


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org