[jira] [Commented] (LUCENE-5896) A view potential reproducible issues

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104022#comment-14104022 ] 

Robert Muir commented on LUCENE-5896:
-------------------------------------

+1

maybe in the future we can use some other strategy to at least detect or avoid such bugs, maybe ThreadLocalRandom?

But please fix these for now, they just stop tests from reproducing and so on.

> A view potential reproducible issues
> ------------------------------------
>
>                 Key: LUCENE-5896
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5896
>             Project: Lucene - Core
>          Issue Type: Test
>          Components: general/test
>    Affects Versions: 4.9
>            Reporter: Simon Willnauer
>             Fix For: 5.0, 4.10
>
>         Attachments: LUCENE-5896.patch
>
>
> I realized that passing the same seeded random instance to LuceneTestCase# newIndewWriterConfig doesn't necessarily produce the same IWC and I found a bunch of issues in that class using global random rather than local random. Yet, I went over the file to spot others but we might need to think about a more automated way to spot those...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org