You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by GitBox <gi...@apache.org> on 2019/09/21 16:07:06 UTC

[GitHub] [johnzon] mkarg commented on issue #46: Enhancement [JOHNZON-278] Return constant instead of new instance of empty block / empty array

mkarg commented on issue #46: Enhancement [JOHNZON-278] Return constant instead of new instance of empty block / empty array
URL: https://github.com/apache/johnzon/pull/46#issuecomment-533809621
 
 
   This PR has to stay in **draft mode** as long as Johnzon depends on Apache Geronimo's JSON-P _buggy_ JSON-P API JARs: In contrast to the _official_ Jakarta JSON-P API JARs, those Apache files implement the empty JsonObject _constant_ in a way which is incompatible with JSON-P's `JsonObject` JavaDocs. As a result, three of Johnzon Core's unit tests will fail. Once Geronimo's JSON-P files are bug-fixed, or once Johnzon Core switches to the official JSON-P files, this PR can be merged safely, as all other tests do pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services