[jira] [Commented] (IMPALA-9907) NullPointerException in ParallelFileMetadataLoader's load() method

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148980#comment-17148980 ] 

ASF subversion and git services commented on IMPALA-9907:
---------------------------------------------------------

Commit 36ced942d84e7237de28a0ebfae785139dbd3836 in impala's branch refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=36ced94 ]

IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

ParallelFileMetadataLoader.loaders_ became a Map, but at one place we
still treat it as a List:

  loaders_.get(i).getPartDir()

'i' is an integer, while the loaders_'s key type is Path.

Unfortunately the code compiled which means we got a
NullPointerException for this statement. I changed the logic to avoid
the NPE.

Testing:

  * Tested manually on an ACID table with deleted rows
  * I didn't add an automated test because I'm about to extend the ACID
    functionalities, hence getting rid of these exceptions
  * The other case when we can hit this NPE is when we get an
    IOException in the file metadata loader's load() method

Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Reviewed-on: http://gerrit.cloudera.org:8080/16121
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> NullPointerException in ParallelFileMetadataLoader's load() method
> ------------------------------------------------------------------
>
>                 Key: IMPALA-9907
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9907
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Zoltán Borók-Nagy
>            Assignee: Zoltán Borók-Nagy
>            Priority: Major
>
> ParallelFileMetadataLoader.loaders_ became a Map, but at one place we still treat it as a List:
> {noformat}
> LOG.error(logPrefix_ + " encountered an error loading data for path " + loaders_.get(i).getPartDir(), e);
> {noformat}
> 'i' is an integer, while the loaders_'s key type is Path.
> Unfortunately the code compiles which means we get a NullPointerException for this statement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org