You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2010/09/29 01:22:09 UTC
svn commit: r1002414 - in /directory/shared/trunk:
ldap-jndi/src/main/java/org/apache/directory/shared/ldap/jndi/
ldap/src/main/java/org/apache/directory/shared/converter/schema/
ldap/src/main/java/org/apache/directory/shared/ldap/codec/ ldap/src/main/...
Author: seelmann
Date: Tue Sep 28 23:22:08 2010
New Revision: 1002414
URL: http://svn.apache.org/viewvc?rev=1002414&view=rev
Log:
Fix checkstyle errors, added TODOs
Modified:
directory/shared/trunk/ldap-jndi/src/main/java/org/apache/directory/shared/ldap/jndi/JndiUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/converter/schema/SchemaToLdif.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapConstants.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/GracefulActionConstants.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/HttpClientError.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/LdapResultEnum.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifRevertor.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/AVASerializer.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/DnSerializer.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnSerializer.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/DescriptionUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/SchemaUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/parsers/ParserDescriptionUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/sp/JavaStoredProcUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/trigger/TriggerUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base32.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base64.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DateUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DirectoryClassUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapExceptionUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapURL.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NamespaceTools.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/PropertiesUtils.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/UTFUtils.java
Modified: directory/shared/trunk/ldap-jndi/src/main/java/org/apache/directory/shared/ldap/jndi/JndiUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-jndi/src/main/java/org/apache/directory/shared/ldap/jndi/JndiUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap-jndi/src/main/java/org/apache/directory/shared/ldap/jndi/JndiUtils.java (original)
+++ directory/shared/trunk/ldap-jndi/src/main/java/org/apache/directory/shared/ldap/jndi/JndiUtils.java Tue Sep 28 23:22:08 2010
@@ -86,6 +86,8 @@ import org.apache.directory.shared.ldap.
/**
* An utility class to convert back and forth JNDI classes to ADS classes.
*
+ * TODO: We have a similar class in shared-ldap!!!
+ *
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public final class JndiUtils
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/converter/schema/SchemaToLdif.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/converter/schema/SchemaToLdif.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/converter/schema/SchemaToLdif.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/converter/schema/SchemaToLdif.java Tue Sep 28 23:22:08 2010
@@ -35,7 +35,7 @@ import org.slf4j.LoggerFactory;
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class SchemaToLdif
+public final class SchemaToLdif
{
/** The ASF Header */
private static final String HEADER = "#\n" + "# Licensed to the Apache Software Foundation (ASF) under one\n"
@@ -54,7 +54,15 @@ public class SchemaToLdif
+ "version: 1\n" + "\n";
/** The logger */
- private static Logger LOG = LoggerFactory.getLogger( SchemaToLdif.class );
+ private static final Logger LOG = LoggerFactory.getLogger( SchemaToLdif.class );
+
+
+ /**
+ * Private constructor.
+ */
+ private SchemaToLdif()
+ {
+ }
/**
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapConstants.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapConstants.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapConstants.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapConstants.java Tue Sep 28 23:22:08 2010
@@ -23,8 +23,15 @@ package org.apache.directory.shared.ldap
/**
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class LdapConstants
+public final class LdapConstants
{
+ /**
+ * Private constructor.
+ */
+ private LdapConstants()
+ {
+ }
+
/** The scope constants */
public static final int SCOPE_BASE_OBJECT = 0;
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java Tue Sep 28 23:22:08 2010
@@ -26,11 +26,21 @@ import org.apache.directory.shared.ldap.
/**
* A Codec to Internal Message transformer.
*
+ * TODO: is this class useful?
+ *
* @author <a href="mailto:dev@directory.apache.org"> Apache Directory Project</a>
*/
-public class LdapTransformer
+public final class LdapTransformer
{
/**
+ * Private constructor.
+ */
+ private LdapTransformer()
+ {
+ }
+
+
+ /**
* Transform the Codec message to a internal message.
*
* @param obj the object to transform
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/GracefulActionConstants.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/GracefulActionConstants.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/GracefulActionConstants.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/GracefulActionConstants.java Tue Sep 28 23:22:08 2010
@@ -25,8 +25,16 @@ package org.apache.directory.shared.ldap
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class GracefulActionConstants
+public final class GracefulActionConstants
{
/** This is the TAG used for the delay. It's a contextual primitive Tag */
public static final int GRACEFUL_ACTION_DELAY_TAG = 0x80;
+
+
+ /**
+ * Private constructor.
+ */
+ private GracefulActionConstants()
+ {
+ }
}
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/HttpClientError.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/HttpClientError.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/HttpClientError.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/HttpClientError.java Tue Sep 28 23:22:08 2010
@@ -24,6 +24,8 @@ package org.apache.directory.shared.ldap
/**
* Signals that an error has occurred.
*
+ * TODO: This class is only used in LdapURL, should be removed.
+ *
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* 2005) $
* @since 3.0
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/LdapResultEnum.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/LdapResultEnum.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/LdapResultEnum.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/util/LdapResultEnum.java Tue Sep 28 23:22:08 2010
@@ -23,6 +23,8 @@ package org.apache.directory.shared.ldap
/**
* This typesafe-enum represent the different resultCode of a LdapResult.
*
+ * TODO: This class is not used!!!
+ *
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public class LdapResultEnum
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifRevertor.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifRevertor.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifRevertor.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifRevertor.java Tue Sep 28 23:22:08 2010
@@ -55,6 +55,14 @@ public final class LdifRevertor
/**
+ * Private constructor.
+ */
+ private LdifRevertor()
+ {
+ }
+
+
+ /**
* Compute a reverse LDIF of an AddRequest. It's simply a delete request
* of the added entry
*
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/ldif/LdifUtils.java Tue Sep 28 23:22:08 2010
@@ -49,10 +49,10 @@ import org.apache.directory.shared.ldap.
public final class LdifUtils
{
/** The array that will be used to match the first char.*/
- private static boolean[] LDIF_SAFE_STARTING_CHAR_ALPHABET = new boolean[128];
+ private static final boolean[] LDIF_SAFE_STARTING_CHAR_ALPHABET = new boolean[128];
/** The array that will be used to match the other chars.*/
- private static boolean[] LDIF_SAFE_OTHER_CHARS_ALPHABET = new boolean[128];
+ private static final boolean[] LDIF_SAFE_OTHER_CHARS_ALPHABET = new boolean[128];
/** The default length for a line in a ldif file */
private static final int DEFAULT_LINE_LENGTH = 80;
@@ -88,6 +88,14 @@ public final class LdifUtils
/**
+ * Private constructor.
+ */
+ private LdifUtils()
+ {
+ }
+
+
+ /**
* Checks if the input String contains only safe values, that is, the data
* does not need to be encoded for use with LDIF. The rules for checking safety
* are based on the rules for LDIF (LDAP Data Interchange Format) per RFC 2849.
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/AVASerializer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/AVASerializer.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/AVASerializer.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/AVASerializer.java Tue Sep 28 23:22:08 2010
@@ -37,11 +37,20 @@ import org.slf4j.LoggerFactory;
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class AVASerializer
+public final class AVASerializer
{
/** The LoggerFactory used by this class */
protected static final Logger LOG = LoggerFactory.getLogger( AVASerializer.class );
+
+ /**
+ * Private constructor.
+ */
+ private AVASerializer()
+ {
+ }
+
+
/**
* Serialize an AttributeTypeAndValue object.
*
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/DnSerializer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/DnSerializer.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/DnSerializer.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/DnSerializer.java Tue Sep 28 23:22:08 2010
@@ -36,11 +36,20 @@ import org.slf4j.LoggerFactory;
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class DnSerializer
+public final class DnSerializer
{
/** The LoggerFactory used by this class */
protected static final Logger LOG = LoggerFactory.getLogger( DnSerializer.class );
+
+ /**
+ * Private constructor.
+ */
+ private DnSerializer()
+ {
+ }
+
+
/**
* Serialize a DN
*
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java Tue Sep 28 23:22:08 2010
@@ -81,9 +81,17 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class RdnParser
+public final class RdnParser
{
/**
+ * Private constructor.
+ */
+ private RdnParser()
+ {
+ }
+
+
+ /**
* Parse a NameComponent : <br>
* <p>
* <name-component> ::= <attributeType> <spaces> '='
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnSerializer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnSerializer.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnSerializer.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnSerializer.java Tue Sep 28 23:22:08 2010
@@ -33,11 +33,20 @@ import org.slf4j.LoggerFactory;
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class RdnSerializer
+public final class RdnSerializer
{
/** The LoggerFactory used by this class */
protected static final Logger LOG = LoggerFactory.getLogger( RdnSerializer.class );
+
+ /**
+ * Private constructor.
+ */
+ private RdnSerializer()
+ {
+ }
+
+
/**
* Serialize a RDN instance
*
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/DescriptionUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/DescriptionUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/DescriptionUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/DescriptionUtils.java Tue Sep 28 23:22:08 2010
@@ -45,9 +45,17 @@ import java.util.Map;
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class DescriptionUtils
+public final class DescriptionUtils
{
/**
+ * Private constructor.
+ */
+ private DescriptionUtils()
+ {
+ }
+
+
+ /**
* Generates the description using the AttributeTypeDescription as defined
* by the syntax: 1.3.6.1.4.1.1466.115.121.1.3. Only the right hand side of
* the description starting at the opening parenthesis is generated: that
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/SchemaUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/SchemaUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/SchemaUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/SchemaUtils.java Tue Sep 28 23:22:08 2010
@@ -41,9 +41,17 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class SchemaUtils
+public final class SchemaUtils
{
/**
+ * Private constructor.
+ */
+ private SchemaUtils()
+ {
+ }
+
+
+ /**
* Gets the target entry as it would look after a modification operation
* were performed on it.
*
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/parsers/ParserDescriptionUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/parsers/ParserDescriptionUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/parsers/ParserDescriptionUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/parsers/ParserDescriptionUtils.java Tue Sep 28 23:22:08 2010
@@ -37,9 +37,17 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class ParserDescriptionUtils
+public final class ParserDescriptionUtils
{
/**
+ * Private constructor.
+ */
+ private ParserDescriptionUtils()
+ {
+ }
+
+
+ /**
* Checks two schema objectClasses for an exact match.
*
* @param oc0 the first objectClass to compare
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/sp/JavaStoredProcUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/sp/JavaStoredProcUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/sp/JavaStoredProcUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/sp/JavaStoredProcUtils.java Tue Sep 28 23:22:08 2010
@@ -44,10 +44,18 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class JavaStoredProcUtils
+public final class JavaStoredProcUtils
{
/**
+ * Private constructor.
+ */
+ private JavaStoredProcUtils()
+ {
+ }
+
+
+ /**
* Returns the stream data of a Java class.
*
* @param clazz
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/trigger/TriggerUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/trigger/TriggerUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/trigger/TriggerUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/trigger/TriggerUtils.java Tue Sep 28 23:22:08 2010
@@ -38,7 +38,7 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class TriggerUtils
+public final class TriggerUtils
{
public static final String TRIGGER_EXECUTION_SPECIFIC_AREA_VALUE = SchemaConstants.TRIGGER_EXECUTION_SPECIFIC_AREA;
public static final String TRIGGER_EXECUTION_SUBENTRY_OC = "triggerExecutionSubentry";
@@ -46,6 +46,14 @@ public class TriggerUtils
public static final String PRESCRIPTIVE_TRIGGER_SPECIFICATION_ATTR = "prescriptiveTriggerSpecification";
+ /**
+ * Private constructor.
+ */
+ private TriggerUtils()
+ {
+ }
+
+
public static void defineTriggerExecutionSpecificPoint( LdapContext apCtx ) throws NamingException
{
Attributes ap = apCtx.getAttributes( "", new String[] { SchemaConstants.ADMINISTRATIVE_ROLE_AT } );
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java Tue Sep 28 23:22:08 2010
@@ -55,8 +55,17 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class AttributeUtils
+public final class AttributeUtils
{
+
+ /**
+ * Private constructor.
+ */
+ private AttributeUtils()
+ {
+ }
+
+
/**
* Correctly removes an attribute from an entry using it's attributeType information.
*
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base32.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base32.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base32.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base32.java Tue Sep 28 23:22:08 2010
@@ -26,14 +26,22 @@ package org.apache.directory.shared.ldap
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class Base32
+public final class Base32
{
private static byte[] CHARS = new byte[]{
'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H',
'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P',
'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X',
'Y', 'Z', '2', '3', '4', '5', '6', '7' };
-
+
+
+ /**
+ * Private constructor.
+ */
+ private Base32()
+ {
+ }
+
public static String encode( String str )
{
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base64.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base64.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base64.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/Base64.java Tue Sep 28 23:22:08 2010
@@ -28,10 +28,18 @@ import org.apache.directory.shared.i18n.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class Base64
+public final class Base64
{
/**
+ * Private constructor.
+ */
+ private Base64()
+ {
+ }
+
+
+ /**
* passed data array.
*
* @param a_data
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java Tue Sep 28 23:22:08 2010
@@ -25,7 +25,7 @@ package org.apache.directory.shared.ldap
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class DNUtils
+public final class DNUtils
{
// ~ Static fields/initializers
// -----------------------------------------------------------------
@@ -50,7 +50,7 @@ public class DNUtils
/** A constant representing two bytes length */
public static final int TWO_BYTES = 2;
- /**
+ /**
* <safe-init-char> ::= [0x01-0x09] | 0x0B | 0x0C | [0x0E-0x1F] |
* [0x21-0x39] | 0x3B | [0x3D-0x7F]
*/
@@ -248,6 +248,15 @@ public class DNUtils
/** "OID." static */
public static final String OID_UPPER = "OID.";
+
+ /**
+ * Private constructor.
+ */
+ private DNUtils()
+ {
+ }
+
+
// ~ Methods
// ------------------------------------------------------------------------------------
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DateUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DateUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DateUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DateUtils.java Tue Sep 28 23:22:08 2010
@@ -31,7 +31,7 @@ import java.util.TimeZone;
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class DateUtils
+public final class DateUtils
{
private static final TimeZone UTC_TIME_ZONE = TimeZone.getTimeZone( "GMT" );
@@ -41,9 +41,17 @@ public class DateUtils
{
dateFormat.setTimeZone( UTC_TIME_ZONE );
}
-
-
- public static Date getDate( String zuluTime )
+
+
+ /**
+ * Private constructor.
+ */
+ private DateUtils()
+ {
+ }
+
+
+ public static Date getDate( String zuluTime )
{
Calendar cal = Calendar.getInstance( UTC_TIME_ZONE );
cal.set( Calendar.YEAR, getYear( zuluTime ) );
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DirectoryClassUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DirectoryClassUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DirectoryClassUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/DirectoryClassUtils.java Tue Sep 28 23:22:08 2010
@@ -29,10 +29,20 @@ import java.util.Arrays;
/**
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class DirectoryClassUtils
+public final class DirectoryClassUtils
{
+ /** The logger. */
private static final Logger LOG = LoggerFactory.getLogger( DirectoryClassUtils.class );
-
+
+
+ /**
+ * Private constructor.
+ */
+ private DirectoryClassUtils()
+ {
+ }
+
+
/**
* A replacement for {@link java.lang.Class#getMethod} with extended capability.
*
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java Tue Sep 28 23:22:08 2010
@@ -87,12 +87,21 @@ import org.apache.directory.shared.ldap.
/**
* An utility class to convert back and forth JNDI classes to ADS classes.
- *
+ *
+ * TODO: We have a similar class in shared-ldap-jndi!!!
+ *
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class JndiUtils
-
+public final class JndiUtils
{
+ /**
+ * Private constructor.
+ */
+ private JndiUtils()
+ {
+ }
+
+
public static javax.naming.ldap.Control toJndiControl( Control control )
{
byte[] value = control.getValue();
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapExceptionUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapExceptionUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapExceptionUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapExceptionUtils.java Tue Sep 28 23:22:08 2010
@@ -31,17 +31,31 @@ import java.util.List;
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class LdapExceptionUtils
+public final class LdapExceptionUtils
{
+ /**
+ * Private constructor
+ */
+ private LdapExceptionUtils()
+ {
+ }
+
+
+ /**
+ * Appends the messages of each Throwable to a string, separated by a new line.
+ *
+ * @param errors the errors
+ * @return the string with all error message
+ */
public static String printErrors( List<Throwable> errors )
{
StringBuilder sb = new StringBuilder();
-
- for ( Throwable error:errors )
+
+ for ( Throwable error : errors )
{
sb.append( "Error : " ).append( error.getMessage() ).append( "\n" );
}
-
+
return sb.toString();
}
}
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapURL.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapURL.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapURL.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/LdapURL.java Tue Sep 28 23:22:08 2010
@@ -662,6 +662,7 @@ public class LdapURL
}
catch ( UnsupportedEncodingException e )
{
+ // TODO: Why do we throw a HttpClientError here?
throw new HttpClientError( I18n.err( I18n.ERR_04413 ) );
}
}
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NamespaceTools.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NamespaceTools.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NamespaceTools.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NamespaceTools.java Tue Sep 28 23:22:08 2010
@@ -33,11 +33,19 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class NamespaceTools
+public final class NamespaceTools
{
private static final String[] EMPTY_STRING_ARRAY = new String[0];
-
+
+ /**
+ * Private constructor
+ */
+ private NamespaceTools()
+ {
+ }
+
+
/**
* Gets the attribute of a single attribute rdn or name component.
*
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/PropertiesUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/PropertiesUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/PropertiesUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/PropertiesUtils.java Tue Sep 28 23:22:08 2010
@@ -37,12 +37,20 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class PropertiesUtils
+public final class PropertiesUtils
{
/** default properties file extension */
private static final String DOTPROPERTIES = ".properties";
+ /**
+ * Private constructor
+ */
+ private PropertiesUtils()
+ {
+ }
+
+
// ------------------------------------------------------------------------
// Utilities for discovering Properties
// ------------------------------------------------------------------------
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java Tue Sep 28 23:22:08 2010
@@ -51,8 +51,15 @@ import org.apache.directory.shared.ldap.
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class StringTools
+public final class StringTools
{
+ /**
+ * Private constructor
+ */
+ private StringTools()
+ {
+ }
+
/** The default charset, because it's not provided by JDK 1.5 */
static String defaultCharset = null;
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/UTFUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/UTFUtils.java?rev=1002414&r1=1002413&r2=1002414&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/UTFUtils.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/UTFUtils.java Tue Sep 28 23:22:08 2010
@@ -36,8 +36,15 @@ import java.io.ObjectOutput;
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
-public class UTFUtils
+public final class UTFUtils
{
+ /**
+ * Private constructor.
+ */
+ private UTFUtils()
+ {
+ }
+
/**
*