You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/28 06:19:53 UTC
[GitHub] [flink] WeiZhong94 opened a new pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
WeiZhong94 opened a new pull request #12372:
URL: https://github.com/apache/flink/pull/12372
## What is the purpose of the change
*This pull request fixes the bug that the config option 'pipeline.jars' doesn't work.*
## Brief change log
- *Transfer the configuration of "pipeline.jars" and "pipeline.classpaths" from TableConfig to ExecEnv in every API that can execute job.*
## Verifying this change
This change is already covered by existing tests, such as *test_table_environment_api.py*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12372:
URL: https://github.com/apache/flink/pull/12372#issuecomment-635131895
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c6d68dbda06b533fce050464330fc633ccac3f9b (Thu May 28 06:22:27 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17946).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #12372:
URL: https://github.com/apache/flink/pull/12372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12372:
URL: https://github.com/apache/flink/pull/12372#issuecomment-635142364
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "65c92cf7403d9a42250667682184481e3dd76c92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2335",
"triggerID" : "65c92cf7403d9a42250667682184481e3dd76c92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65c92cf7403d9a42250667682184481e3dd76c92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12372:
URL: https://github.com/apache/flink/pull/12372#issuecomment-635707647
@WeiZhong94 Thanks for the update. LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12372:
URL: https://github.com/apache/flink/pull/12372#issuecomment-635142364
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "65c92cf7403d9a42250667682184481e3dd76c92",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65c92cf7403d9a42250667682184481e3dd76c92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65c92cf7403d9a42250667682184481e3dd76c92 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12372:
URL: https://github.com/apache/flink/pull/12372#issuecomment-635142364
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "65c92cf7403d9a42250667682184481e3dd76c92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2335",
"triggerID" : "65c92cf7403d9a42250667682184481e3dd76c92",
"triggerType" : "PUSH"
}, {
"hash" : "b9759904d50a3d2f99aa9dbbcb42dc3b2d64f5b9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b9759904d50a3d2f99aa9dbbcb42dc3b2d64f5b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65c92cf7403d9a42250667682184481e3dd76c92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2335)
* b9759904d50a3d2f99aa9dbbcb42dc3b2d64f5b9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12372:
URL: https://github.com/apache/flink/pull/12372#issuecomment-635142364
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "65c92cf7403d9a42250667682184481e3dd76c92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2335",
"triggerID" : "65c92cf7403d9a42250667682184481e3dd76c92",
"triggerType" : "PUSH"
}, {
"hash" : "b9759904d50a3d2f99aa9dbbcb42dc3b2d64f5b9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2345",
"triggerID" : "b9759904d50a3d2f99aa9dbbcb42dc3b2d64f5b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65c92cf7403d9a42250667682184481e3dd76c92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2335)
* b9759904d50a3d2f99aa9dbbcb42dc3b2d64f5b9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2345)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] WeiZhong94 commented on pull request #12372: [FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work.
Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on pull request #12372:
URL: https://github.com/apache/flink/pull/12372#issuecomment-635164299
@dianfu Thanks for your review! I have addressed your comments. It is unnecessary to execute `_before_execute()` in `sql_update` as it won't execute the pipeline really.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org