[jira] [Commented] (THRIFT-2249) Add SMP Build option to thrift.spec (and three config defines)

["Jake Farrell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833495#comment-13833495 ] 

Jake Farrell commented on THRIFT-2249:
--------------------------------------

since there is a "+%define without_java 1" why is there no check for it like %{?without_java:    --without-java    } \ and it just assumed with  --without-java \ ? same applies for python check. otherwise patch looks good

> Add SMP Build option to thrift.spec (and three config defines)
> --------------------------------------------------------------
>
>                 Key: THRIFT-2249
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2249
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process
>    Affects Versions: 0.9.1
>         Environment: RPM Build
>            Reporter: Martin Vogt
>            Priority: Trivial
>         Attachments: thrift_spec.patch
>
>
> Hello,
> the patch improves the .spec file in contrib/.
> - parallel build option
> - add defines
> Tested on OpenSuSe 12.2.
> regards,
> Martin



--
This message was sent by Atlassian JIRA
(v6.1#6144)