You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "haohao0103 (via GitHub)" <gi...@apache.org> on 2024/12/23 07:19:02 UTC
[PR] TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier [tinkerpop]
haohao0103 opened a new pull request, #2956:
URL: https://github.com/apache/tinkerpop/pull/2956
TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2956:
URL: https://github.com/apache/tinkerpop/pull/2956#issuecomment-2634678378
Hi @haohao0103, I'm going to close this PR for now as no activity has taken place. If you're still interested in pursuing this change, please restart the conversation in the JIRA or on the TinkerPop dev mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2956:
URL: https://github.com/apache/tinkerpop/pull/2956#issuecomment-2568100781
Thanks for opening the PR @haohao0103, could you expand on your reasons for removing the `@Override` annotation here? This method is overriding the implementation from the [World](https://github.com/apache/tinkerpop/blob/087b3070914123055d3e4ededc2550f12715a0b4/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/World.java#L89-L91) class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer closed pull request #2956: TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier
URL: https://github.com/apache/tinkerpop/pull/2956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2956:
URL: https://github.com/apache/tinkerpop/pull/2956#issuecomment-2622400092
Hi @haohao0103, are you still looking to have this change accepted into TinkerPop? I think we need a brief discussion of the motivations for the change in the JIRA before we can proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2956:
URL: https://github.com/apache/tinkerpop/pull/2956#issuecomment-2560225161
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2956?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 78.07%. Comparing base [(`cfd6889`)](https://app.codecov.io/gh/apache/tinkerpop/commit/cfd68897ea111e3ae7100dbc2f0f7a364fd0ffa5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`51f49e4`)](https://app.codecov.io/gh/apache/tinkerpop/commit/51f49e408a08a4e778712ef78f73d0b697806568?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 56 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2956 +/- ##
============================================
+ Coverage 77.87% 78.07% +0.19%
- Complexity 13578 13889 +311
============================================
Files 1015 1019 +4
Lines 59308 59816 +508
Branches 6835 6925 +90
============================================
+ Hits 46184 46699 +515
+ Misses 10817 10798 -19
- Partials 2307 2319 +12
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2956?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2956:
URL: https://github.com/apache/tinkerpop/pull/2956#issuecomment-2568143046
Sorry I saw this PR before seeing the associated JIRA: [TINKERPOP-3123](https://issues.apache.org/jira/browse/TINKERPOP-3123). Let's continue the discussion there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org