You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2025/03/20 07:42:43 UTC
[PR] [fix][test] Move ReplicatorRateLimiterTest to broker test group [pulsar]
nodece opened a new pull request, #24101:
URL: https://github.com/apache/pulsar/pull/24101
### Motivation
The `ReplicatorRateLimiterTest` is crucial for verifying the correct behavior of the rate limiter in replication scenarios. If this test is marked as part of the `quarantine` test group, its failure will not block PR merges. This poses a risk: if the replicator limiter is broken, we will not detect regressions promptly.
To maintain reliability and catch potential issues early, this test should remain a required test and not be moved to `quarantine`.
### Modifications
- Move `ReplicatorRateLimiterTest` from the `quarantine` test group to the `broker` test group
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Move ReplicatorRateLimiterTest to broker test group [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #24101:
URL: https://github.com/apache/pulsar/pull/24101#issuecomment-2742551134
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Move ReplicatorRateLimiterTest to broker test group [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24101:
URL: https://github.com/apache/pulsar/pull/24101#issuecomment-2742740314
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24101?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 74.24%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e4104c5`)](https://app.codecov.io/gh/apache/pulsar/commit/e4104c54af61cf5ece8ab8f3d43b5752e2cd187f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 980 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/24101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #24101 +/- ##
============================================
+ Coverage 73.57% 74.24% +0.66%
+ Complexity 32624 32463 -161
============================================
Files 1877 1864 -13
Lines 139502 144332 +4830
Branches 15299 16463 +1164
============================================
+ Hits 102638 107154 +4516
+ Misses 28908 28723 -185
- Partials 7956 8455 +499
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/24101/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/24101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.67% <ø> (+2.09%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/24101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.13% <ø> (-1.19%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/24101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.74% <ø> (+0.90%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1066 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/24101/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Move ReplicatorRateLimiterTest to broker test group [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #24101:
URL: https://github.com/apache/pulsar/pull/24101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org