[spark] branch branch-2.4 updated: Revert "[SPARK-29777][FOLLOW-UP][SPARKR] Remove no longer valid test for recursive calls"

[gu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new 5f1cb2f  Revert "[SPARK-29777][FOLLOW-UP][SPARKR] Remove no longer valid test for recursive calls"
5f1cb2f is described below

commit 5f1cb2fe86b1b624c8f89121f12e01c5539bdafe
Author: HyukjinKwon <gu...@apache.org>
AuthorDate: Sun Jan 26 14:43:49 2020 +0900

    Revert "[SPARK-29777][FOLLOW-UP][SPARKR] Remove no longer valid test for recursive calls"
    
    This reverts commit 81ea5a4cc1617de0dbbc61811847320724b3644f.
---
 R/pkg/tests/fulltests/test_utils.R | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/R/pkg/tests/fulltests/test_utils.R b/R/pkg/tests/fulltests/test_utils.R
index ff52ced..b2b6f34 100644
--- a/R/pkg/tests/fulltests/test_utils.R
+++ b/R/pkg/tests/fulltests/test_utils.R
@@ -89,10 +89,7 @@ test_that("cleanClosure on R functions", {
     lapply(x, g) + 1  # Test for capturing function call "g"'s closure as a argument of lapply.
     l$field[1, 1] <- 3  # Test for access operators `$`.
     res <- defUse + l$field[1, ]  # Test for def-use chain of "defUse", and "" symbol.
-    # Enable once SPARK-30629 is fixed
-    # nolint start
-    # f(res)  # Test for recursive calls.
-    # nolint end
+    f(res)  # Test for recursive calls.
   }
   newF <- cleanClosure(f)
   env <- environment(newF)
@@ -104,10 +101,7 @@ test_that("cleanClosure on R functions", {
   # nolint end
   expect_true("g" %in% ls(env))
   expect_true("l" %in% ls(env))
-  # Enable once SPARK-30629 is fixed
-  # nolint start
-  # expect_true("f" %in% ls(env))
-  # nolint end
+  expect_true("f" %in% ls(env))
   expect_equal(get("l", envir = env, inherits = FALSE), l)
   # "y" should be in the environment of g.
   newG <- get("g", envir = env, inherits = FALSE)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org