[GitHub] [hive] deniskuzZ commented on a diff in pull request #4077: HIVE-26735: Ability to sort the data during rebalancing compaction

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #4077:
URL: https://github.com/apache/hive/pull/4077#discussion_r1126204883


##########
ql/src/java/org/apache/hadoop/hive/ql/Compiler.java:
##########
@@ -263,7 +263,7 @@ private void setLastReplIdForDump(HiveConf conf) throws HiveException, TExceptio
 
   private void openTransaction(TxnType txnType) throws LockException, CommandProcessorException {
     if (DriverUtils.checkConcurrency(driverContext) && startImplicitTxn(driverContext.getTxnManager()) &&
-        !driverContext.getTxnManager().isTxnOpen() && txnType != TxnType.COMPACTION) {
+        !driverContext.getTxnManager().isTxnOpen() && txnType != TxnType.COMPACTION && txnType != TxnType.REBALANCE_COMPACTION) {

Review Comment:
   could we extract the compaction part into a helper method `isCompactionTxn()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org