You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/03/21 00:35:06 UTC
[GitHub] [dubbo] codecov-io commented on issue #5898: duplicate code
in MulticastGroup.java and MulticastExchangeGroup.java
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr&el=h1) Report
> Merging [#5898](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/84bc2616a5c6be6542ab5bb564c51f876d24bdb1&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5898 +/- ##
============================================
- Coverage 61.21% 61.18% -0.04%
+ Complexity 497 496 -1
============================================
Files 981 981
Lines 39147 39092 -55
Branches 5645 5609 -36
============================================
- Hits 23963 23917 -46
+ Misses 12554 12548 -6
+ Partials 2630 2627 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/p2p/exchange/support/MulticastExchangeGroup.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvZXhjaGFuZ2Uvc3VwcG9ydC9NdWx0aWNhc3RFeGNoYW5nZUdyb3VwLmphdmE=) | `77.50% <0.00%> (+5.15%)` | `0.00 <0.00> (ø)` | |
| [...che/dubbo/remoting/p2p/support/MulticastGroup.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9NdWx0aWNhc3RHcm91cC5qYXZh) | `82.50% <0.00%> (+5.90%)` | `0.00 <0.00> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `67.61% <42.85%> (-0.75%)` | `0.00 <0.00> (ø)` | |
| [.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9Bc3luY1RvU3luY0ludm9rZXIuamF2YQ==) | `62.06% <0.00%> (-10.35%)` | `0.00% <0.00%> (ø%)` | |
| [...he/dubbo/common/threadpool/ThreadlessExecutor.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9UaHJlYWRsZXNzRXhlY3V0b3IuamF2YQ==) | `52.17% <0.00%> (-10.87%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0.00%> (-5.27%)` | `0.00% <0.00%> (ø%)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0.00%> (-4.35%)` | `0.00% <0.00%> (ø%)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `52.27% <0.00%> (-3.41%)` | `19.00% <0.00%> (-1.00%)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `75.89% <0.00%> (-3.42%)` | `0.00% <0.00%> (ø%)` | |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `86.66% <0.00%> (-1.91%)` | `16.00% <0.00%> (ø%)` | |
| ... and [6 more](https://codecov.io/gh/apache/dubbo/pull/5898/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr&el=footer). Last update [84bc261...3823a1a](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5898 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org