You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/17 20:55:07 UTC

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #10909: fix: several disabled pylint rules in models/helpers.py

willbarrett commented on a change in pull request #10909:
URL: https://github.com/apache/incubator-superset/pull/10909#discussion_r490555076



##########
File path: superset/models/helpers.py
##########
@@ -66,14 +63,6 @@ class ImportMixin:
     # The names of the attributes
     # that are available for import and export
 
-    @classmethod

Review comment:
       Yes, I think making it public is a good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org