You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/08/21 07:50:41 UTC
[GitHub] [incubator-echarts] Ovilia opened a new pull request #13170: feat: dirty rect
Ovilia opened a new pull request #13170:
URL: https://github.com/apache/incubator-echarts/pull/13170
See https://github.com/ecomfe/zrender/pull/570 for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13170: feat: dirty rect
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13170:
URL: https://github.com/apache/incubator-echarts/pull/13170#issuecomment-678098880
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13170: feat(dirty-rect): Using dirty rectangles to render charts
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13170:
URL: https://github.com/apache/incubator-echarts/pull/13170#issuecomment-709914002
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request #13170: feat(dirty-rect): Using dirty rectangles to render charts
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #13170:
URL: https://github.com/apache/incubator-echarts/pull/13170#discussion_r475346004
##########
File path: src/echarts.ts
##########
@@ -344,11 +345,23 @@ class ECharts extends Eventful {
) as any).__ECHARTS__DEFAULT__RENDERER__ || defaultRenderer;
}
+ let defaultUseDirtyRect = false;
+ if (__DEV__) {
+ const devUseDirtyRect = ((
+ typeof window === 'undefined' ? global : window
+ ) as any).__ECHARTS__DEFAULT__USE_DIRTY_RECT__;
+
Review comment:
We can reuse the logic of getting window or global in https://github.com/apache/incubator-echarts/blob/97b1473315f6f4dacc5b14fafce4b0a00f064722/src/echarts.ts#L344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13170: feat(dirty-rect): Using dirty rectangles to render charts
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13170:
URL: https://github.com/apache/incubator-echarts/pull/13170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org