You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/06 13:15:25 UTC

[GitHub] mxm commented on a change in pull request #7641: [FLINK-11513] Port CliFrontendSavepointTest to new code base

mxm commented on a change in pull request #7641: [FLINK-11513] Port CliFrontendSavepointTest to new code base
URL: https://github.com/apache/flink/pull/7641#discussion_r254265020
 
 

 ##########
 File path: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendSavepointTest.java
 ##########
 @@ -282,12 +279,14 @@ public void testDisposeSavepointFailure() throws Exception {
 
 	// ------------------------------------------------------------------------
 
-	private static final class DisposeSavepointClusterClient extends StandaloneClusterClient {
+	private static final class DisposeSavepointClusterClient extends RestClusterClient<StandaloneClusterId> {
 
 Review comment:
   Does this remove test coverage for the old client?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services