[GitHub] [geode] mivanac commented on a change in pull request #6013: GEODE-8768_1: modify getMemberName method

[GitBox <gi...@apache.org>]

mivanac commented on a change in pull request #6013:
URL: https://github.com/apache/geode/pull/6013#discussion_r574346702



##########
File path: geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorHelper.java
##########
@@ -46,13 +46,42 @@ public static boolean addLocator(int distributedSystemId, DistributionLocatorId
     Set<DistributionLocatorId> existingValue =
         allLocatorsInfo.putIfAbsent(distributedSystemId, locatorsSet);
     if (existingValue != null) {
-      if (!existingValue.contains(locator)) {
+      if (locator.getMemberName() != null) {

Review comment:
       Hi, I added this part to cover empty string
   
     public String getMemberName() {
       if (this.membername != null && this.membername == "")
         return null;
   
       return this.membername;
     }
   
   , but can also add to have empty string instead of null.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org