You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by pujav65 <gi...@git.apache.org> on 2016/10/07 15:28:30 UTC
[GitHub] incubator-rya pull request #101: RYA-177 adding optional geoindexing profile
GitHub user pujav65 opened a pull request:
https://github.com/apache/incubator-rya/pull/101
RYA-177 adding optional geoindexing profile
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
>What Changed?
Moved geoindexing to a separate project and added a profile.
### Tests
>Coverage?
N/A
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-177)
### Checklist
- [ ] Code Review
- [ x] Squash Commits
#### People To Reivew
@amihalik
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pujav65/incubator-rya RYA-177
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
commit 7727b1651b734d4b06d518032897f0c0dc4f88d5
Author: pujav65 <pu...@gmail.com>
Date: 2016-10-07T15:26:43Z
RYA-177 adding optional geoindexing profile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #101: [WIP] RYA-177 adding optional geoindexing profile
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the issue:
https://github.com/apache/incubator-rya/pull/101
Better. I'm still seeing gt dependencies.
try running `mvn dependency:tree | grep gt` in your environment. I get this:
```
[INFO] | | | +- org.geotools:gt-referencing:jar:14.1:compile
[INFO] | | | +- org.geotools:gt-grid:jar:14.1:compile
[INFO] | | | \- org.geotools:gt-transform:jar:14.1:compile
[INFO] | | +- org.geotools:gt-main:jar:14.1:compile
[INFO] | | +- org.geotools:gt-api:jar:14.1:compile
[INFO] | | +- org.geotools:gt-data:jar:14.1:compile
[INFO] | | +- org.geotools:gt-cql:jar:14.1:compile
[INFO] | | +- org.geotools:gt-metadata:jar:14.1:compile
[INFO] | | +- org.geotools:gt-render:jar:14.1:compile
[INFO] | | | \- org.geotools:gt-coverage:jar:14.1:compile
[INFO] | | +- org.geotools:gt-process-feature:jar:14.1:compile
[INFO] | | | \- org.geotools:gt-process:jar:14.1:compile
[INFO] | | | \- org.geotools:gt-shapefile:jar:14.1:compile
[INFO] | +- org.geotools:gt-opengis:jar:14.1:compile
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #101: RYA-177 adding optional geoindexing profile
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/incubator-rya/pull/101
Looks reasonable enough. I'll try to pull down the changes and take a look tmrw with fresh eyes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #101: RYA-177 adding optional geoindexing profile
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #101: [WIP] RYA-177 adding optional geoindexing profile
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/101
This is meant to be a start to get us through a release -- there are at least three issues that should accompany this:
1. Bring back the geo examples
2. Have Map Reduce delegate to the DAO to write to indexers, not writing to them directly
3. Look at further refactoring to bring back the mongo geoindexing since it doesn't implicitly depend on geotools
I feel these are all relatively minor and could be solved later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #101: [WIP] RYA-177 adding optional geoindexing profile
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the issue:
https://github.com/apache/incubator-rya/pull/101
Yep, I will missing a commit. Looks good. Building and running the tests now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #101: [WIP] RYA-177 adding optional geoindexing profile
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/101
Sorry missed the jt dependency that was pulling those in. Let me know if you see anything else being pulled in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #101: [WIP] RYA-177 adding optional geoindexing profile
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the issue:
https://github.com/apache/incubator-rya/pull/101
I'm still seeing gt libs pulled into the build eg:
```
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Rya Secondary Indexing 3.2.10-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[...]
[INFO] Including org.geotools.xsd:gt-xsd-core:jar:14.3 in the shaded jar.
[INFO] Including org.geotools:gt-graph:jar:14.3 in the shaded jar.
```
What's the plan to resolve these before a release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #101: [WIP] RYA-177 adding optional geoindexing profile
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/101
hey aaron i can't recreate this. Can you verify that you are running with the geoindexing profile not enabled and that you have my last commit? I ran mvn dependency:tree, piped to file, and then searched for gt. Didn't bring this up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---