You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Glen Mazza <gl...@gmail.com> on 2013/01/11 04:20:03 UTC
Switch to static jdbc.properties for testing?
Hi Team,
I was wondering if we could have our tests switch to a static
jdbc.properties file instead of having one dynamically created (this is
the jdbc.properties that appears in tests/etc/db during the Ant tests).
This will help both in Mavenization (where I can just make reference to
a static reference file instead of duplicating a lot of build.xml into
the Maven Antrun plugin) and in simplifying our present build.xml. Here
is its present contents (created before the tests run):
#Ant properties
#Thu Jan 10 21:25:38 EST 2013
jdbc.admin.id=SA
jdbc.admin.password=
jdbc.driver.class=org.hsqldb.jdbcDriver
jdbc.driver.id=hsql
jdbc.driver.jar=tests/lib/hsqldb-1.8.0.10.jar
jdbc.driver.url=jdbc\:hsqldb\:hsql\://localhost/jspwiki
jdbc.jar.present=tests/lib/hsqldb-1.8.0.10.jar
jdbc.user.id=jspwiki
jdbc.user.password=password
As you can see, it's a very small, easy-to-understand file that can work
the same for everyone, but to generate that takes lines 1462-1519 here:
http://svn.apache.org/viewvc/incubator/jspwiki/trunk/build.xml?view=markup#l1462,
much harder to understand.
If OK, I'll go ahead and make this change in the build.xml and confirm
that our tests will all run fine with it and then update the Maven
pom.xml we have in JIRA. There's a few more dynamically generated files
I may make similar requests for, but we can get to those later.
Ideally, I'd like to see the jspwiki.properties that we use for testing
(production can still be dynamically generated) be static and checked
into SVN, and if we need multiple jspwiki.properties depending on what
we're testing, to have static multiple versions then. It makes the
build.xml/pom.xml as well as testing/conversion between the two so much
simpler. The Mavenized projects I'm used to (CXF, Roller, Camel, etc.)
just use the same static test resources as part of their "mvn clean
install" or "mvn test" runs, allowing you to look at those resource
files and immediately see their contents rather than go through the
build.xml/pom.xml to try to figure out what those files contain.
Regards,
Glen
Re: Switch to static jdbc.properties for testing?
Posted by Juan Pablo Santos RodrÃguez <ju...@gmail.com>.
+1 too
br,
jp
On Fri, Jan 11, 2013 at 9:21 AM, Harry Metske <ha...@gmail.com>wrote:
> +1
>
>
> On 11 January 2013 04:20, Glen Mazza <gl...@gmail.com> wrote:
>
> > Hi Team,
> >
> > I was wondering if we could have our tests switch to a static
> > jdbc.properties file instead of having one dynamically created (this is
> the
> > jdbc.properties that appears in tests/etc/db during the Ant tests). This
> > will help both in Mavenization (where I can just make reference to a
> static
> > reference file instead of duplicating a lot of build.xml into the Maven
> > Antrun plugin) and in simplifying our present build.xml. Here is its
> > present contents (created before the tests run):
> >
> > #Ant properties
> > #Thu Jan 10 21:25:38 EST 2013
> > jdbc.admin.id=SA
> > jdbc.admin.password=
> > jdbc.driver.class=org.hsqldb.**jdbcDriver
> > jdbc.driver.id=hsql
> > jdbc.driver.jar=tests/lib/**hsqldb-1.8.0.10.jar
> > jdbc.driver.url=jdbc\:hsqldb\:**hsql\://localhost/jspwiki
> > jdbc.jar.present=tests/lib/**hsqldb-1.8.0.10.jar
> > jdbc.user.id=jspwiki
> > jdbc.user.password=password
> >
> > As you can see, it's a very small, easy-to-understand file that can work
> > the same for everyone, but to generate that takes lines 1462-1519 here:
> > http://svn.apache.org/viewvc/**incubator/jspwiki/trunk/build.**
> > xml?view=markup#l1462<
> http://svn.apache.org/viewvc/incubator/jspwiki/trunk/build.xml?view=markup#l1462
> >,
> > much harder to understand.
> >
> > If OK, I'll go ahead and make this change in the build.xml and confirm
> > that our tests will all run fine with it and then update the Maven
> pom.xml
> > we have in JIRA. There's a few more dynamically generated files I may
> make
> > similar requests for, but we can get to those later. Ideally, I'd like
> to
> > see the jspwiki.properties that we use for testing (production can still
> be
> > dynamically generated) be static and checked into SVN, and if we need
> > multiple jspwiki.properties depending on what we're testing, to have
> static
> > multiple versions then. It makes the build.xml/pom.xml as well as
> > testing/conversion between the two so much simpler. The Mavenized
> projects
> > I'm used to (CXF, Roller, Camel, etc.) just use the same static test
> > resources as part of their "mvn clean install" or "mvn test" runs,
> allowing
> > you to look at those resource files and immediately see their contents
> > rather than go through the build.xml/pom.xml to try to figure out what
> > those files contain.
> >
> > Regards,
> > Glen
> >
> >
>
Re: Switch to static jdbc.properties for testing?
Posted by Harry Metske <ha...@gmail.com>.
+1
On 11 January 2013 04:20, Glen Mazza <gl...@gmail.com> wrote:
> Hi Team,
>
> I was wondering if we could have our tests switch to a static
> jdbc.properties file instead of having one dynamically created (this is the
> jdbc.properties that appears in tests/etc/db during the Ant tests). This
> will help both in Mavenization (where I can just make reference to a static
> reference file instead of duplicating a lot of build.xml into the Maven
> Antrun plugin) and in simplifying our present build.xml. Here is its
> present contents (created before the tests run):
>
> #Ant properties
> #Thu Jan 10 21:25:38 EST 2013
> jdbc.admin.id=SA
> jdbc.admin.password=
> jdbc.driver.class=org.hsqldb.**jdbcDriver
> jdbc.driver.id=hsql
> jdbc.driver.jar=tests/lib/**hsqldb-1.8.0.10.jar
> jdbc.driver.url=jdbc\:hsqldb\:**hsql\://localhost/jspwiki
> jdbc.jar.present=tests/lib/**hsqldb-1.8.0.10.jar
> jdbc.user.id=jspwiki
> jdbc.user.password=password
>
> As you can see, it's a very small, easy-to-understand file that can work
> the same for everyone, but to generate that takes lines 1462-1519 here:
> http://svn.apache.org/viewvc/**incubator/jspwiki/trunk/build.**
> xml?view=markup#l1462<http://svn.apache.org/viewvc/incubator/jspwiki/trunk/build.xml?view=markup#l1462>,
> much harder to understand.
>
> If OK, I'll go ahead and make this change in the build.xml and confirm
> that our tests will all run fine with it and then update the Maven pom.xml
> we have in JIRA. There's a few more dynamically generated files I may make
> similar requests for, but we can get to those later. Ideally, I'd like to
> see the jspwiki.properties that we use for testing (production can still be
> dynamically generated) be static and checked into SVN, and if we need
> multiple jspwiki.properties depending on what we're testing, to have static
> multiple versions then. It makes the build.xml/pom.xml as well as
> testing/conversion between the two so much simpler. The Mavenized projects
> I'm used to (CXF, Roller, Camel, etc.) just use the same static test
> resources as part of their "mvn clean install" or "mvn test" runs, allowing
> you to look at those resource files and immediately see their contents
> rather than go through the build.xml/pom.xml to try to figure out what
> those files contain.
>
> Regards,
> Glen
>
>