You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "metecanakar (via GitHub)" <gi...@apache.org> on 2023/10/18 20:41:22 UTC
[PR] Typo fixed yyy to yyyy [spark]
metecanakar opened a new pull request, #43442:
URL: https://github.com/apache/spark/pull/43442
### What changes were proposed in this pull request?
There is a typo in the year format. Instead of '`MM/dd/yyy'`, it should be `'MM/dd/yyyy'`
### Does this PR introduce _any_ user-facing change?
No
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][PYTHON][DOCS] Typo fixed yyy to yyyy at date_format function [spark]
Posted by "metecanakar (via GitHub)" <gi...@apache.org>.
metecanakar commented on PR #43442:
URL: https://github.com/apache/spark/pull/43442#issuecomment-1771448937
> Mind taking a look at https://github.com/apache/spark/pull/43442/checks?check_run_id=17836826969? Let's also file a JIRA, see also https://spark.apache.org/contributing.html
Issue (https://issues.apache.org/jira/browse/SPARK-45611) created and also attaching it to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Typo fixed yyy to yyyy [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43442:
URL: https://github.com/apache/spark/pull/43442#issuecomment-1769879428
Mind taking a look at https://github.com/apache/spark/pull/43442/checks?check_run_id=17836826969? Let's also file a JIRA, see also https://spark.apache.org/contributing.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45611][PYTHON][DOCS] Typo fixed yyy to yyyy at date_format function [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #43442:
URL: https://github.com/apache/spark/pull/43442#discussion_r1366658227
##########
python/pyspark/sql/functions.py:
##########
@@ -6784,7 +6784,7 @@ def date_format(date: "ColumnOrName", format: str) -> Column:
Examples
--------
>>> df = spark.createDataFrame([('2015-04-08',)], ['dt'])
- >>> df.select(date_format('dt', 'MM/dd/yyy').alias('date')).collect()
+ >>> df.select(date_format('dt', 'MM/dd/yyyy').alias('date')).collect()
Review Comment:
This might be a typo but not a bug because 3-y means minimum number not exact number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45611][PYTHON][DOCS] Typo fixed yyy to yyyy at date_format function [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43442:
URL: https://github.com/apache/spark/pull/43442#issuecomment-1771870803
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][PYTHON][DOCS] Typo fixed yyy to yyyy at date_format function [spark]
Posted by "metecanakar (via GitHub)" <gi...@apache.org>.
metecanakar commented on PR #43442:
URL: https://github.com/apache/spark/pull/43442#issuecomment-1770830518
> Mind taking a look at https://github.com/apache/spark/pull/43442/checks?check_run_id=17836826969? Let's also file a JIRA, see also https://spark.apache.org/contributing.html
It should be fine now. I will open a Jira issue later on today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45611][PYTHON][DOCS] Typo fixed yyy to yyyy at date_format function [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43442: [SPARK-45611][PYTHON][DOCS] Typo fixed yyy to yyyy at date_format function
URL: https://github.com/apache/spark/pull/43442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45611][PYTHON][DOCS] Typo fixed yyy to yyyy at date_format function [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #43442:
URL: https://github.com/apache/spark/pull/43442#discussion_r1366658227
##########
python/pyspark/sql/functions.py:
##########
@@ -6784,7 +6784,7 @@ def date_format(date: "ColumnOrName", format: str) -> Column:
Examples
--------
>>> df = spark.createDataFrame([('2015-04-08',)], ['dt'])
- >>> df.select(date_format('dt', 'MM/dd/yyy').alias('date')).collect()
+ >>> df.select(date_format('dt', 'MM/dd/yyyy').alias('date')).collect()
Review Comment:
This might be a type but not a bug because 3-y means minimum number not exact number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45611][PYTHON][DOCS] Typo fixed yyy to yyyy at date_format function [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #43442:
URL: https://github.com/apache/spark/pull/43442#discussion_r1366659649
##########
python/pyspark/sql/functions.py:
##########
@@ -6784,7 +6784,7 @@ def date_format(date: "ColumnOrName", format: str) -> Column:
Examples
--------
>>> df = spark.createDataFrame([('2015-04-08',)], ['dt'])
- >>> df.select(date_format('dt', 'MM/dd/yyy').alias('date')).collect()
+ >>> df.select(date_format('dt', 'MM/dd/yyyy').alias('date')).collect()
Review Comment:
We should run all examples, and as you can see the output is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org