You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2017/07/17 19:36:12 UTC
Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights
to HDP, EU needs to set hive-site custom.hive.warehouse.mode to 0770
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/
-----------------------------------------------------------
Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-21502
https://issues.apache.org/jira/browse/AMBARI-21502
Repository: ambari
Description
-------
During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
EU should set the value of custom.hive.warehouse.mode to 0770
Diffs
-----
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
Diff: https://reviews.apache.org/r/60919/diff/1/
Testing
-------
Python unit tests passed.
----------------------------------------------------------------------
Total run:1161
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/#review180725
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
Line 137 (original), 137 (patched)
<https://reviews.apache.org/r/60919/#comment255944>
The id here was wrong, so just dropped the last 2 digits.
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
Line 170 (original), 170 (patched)
<https://reviews.apache.org/r/60919/#comment255945>
The id here was wrong, so just dropped the last 2 digits.
- Alejandro Fernandez
On July 17, 2017, 7:36 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60919/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 7:36 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21502
> https://issues.apache.org/jira/browse/AMBARI-21502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
> EU should set the value of custom.hive.warehouse.mode to 0770
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
>
>
> Diff: https://reviews.apache.org/r/60919/diff/1/
>
>
> Testing
> -------
>
> Python unit tests passed.
>
> ----------------------------------------------------------------------
> Total run:1161
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On July 17, 2017, 8:16 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
> > Lines 177 (patched)
> > <https://reviews.apache.org/r/60919/diff/1/?file=1777947#file1777947line177>
> >
> > Will this set the value only if the property does not exist so that user supplied value is not over-written?
Just fixed it, should only set the property value if not already present so as to not overwrite an existing custom value.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/#review180732
-----------------------------------------------------------
On July 17, 2017, 9:31 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60919/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 9:31 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21502
> https://issues.apache.org/jira/browse/AMBARI-21502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
> EU should set the value of custom.hive.warehouse.mode to 0770
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
>
>
> Diff: https://reviews.apache.org/r/60919/diff/2/
>
>
> Testing
> -------
>
> Python unit tests passed.
>
> ----------------------------------------------------------------------
> Total run:1161
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/#review180732
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
Lines 177 (patched)
<https://reviews.apache.org/r/60919/#comment255949>
Will this set the value only if the property does not exist so that user supplied value is not over-written?
- Sumit Mohanty
On July 17, 2017, 7:36 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60919/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 7:36 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21502
> https://issues.apache.org/jira/browse/AMBARI-21502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
> EU should set the value of custom.hive.warehouse.mode to 0770
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
>
>
> Diff: https://reviews.apache.org/r/60919/diff/1/
>
>
> Testing
> -------
>
> Python unit tests passed.
>
> ----------------------------------------------------------------------
> Total run:1161
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/#review180785
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On July 17, 2017, 5:31 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60919/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 5:31 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21502
> https://issues.apache.org/jira/browse/AMBARI-21502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
> EU should set the value of custom.hive.warehouse.mode to 0770
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
>
>
> Diff: https://reviews.apache.org/r/60919/diff/2/
>
>
> Testing
> -------
>
> Python unit tests passed.
>
> ----------------------------------------------------------------------
> Total run:1161
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/#review180747
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On July 17, 2017, 9:31 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60919/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 9:31 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21502
> https://issues.apache.org/jira/browse/AMBARI-21502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
> EU should set the value of custom.hive.warehouse.mode to 0770
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
>
>
> Diff: https://reviews.apache.org/r/60919/diff/2/
>
>
> Testing
> -------
>
> Python unit tests passed.
>
> ----------------------------------------------------------------------
> Total run:1161
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/#review180748
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Grinenko
On July 17, 2017, 9:31 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60919/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 9:31 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21502
> https://issues.apache.org/jira/browse/AMBARI-21502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
> EU should set the value of custom.hive.warehouse.mode to 0770
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
>
>
> Diff: https://reviews.apache.org/r/60919/diff/2/
>
>
> Testing
> -------
>
> Python unit tests passed.
>
> ----------------------------------------------------------------------
> Total run:1161
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/
-----------------------------------------------------------
(Updated July 17, 2017, 9:31 p.m.)
Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-21502
https://issues.apache.org/jira/browse/AMBARI-21502
Repository: ambari
Description
-------
During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
EU should set the value of custom.hive.warehouse.mode to 0770
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
Diff: https://reviews.apache.org/r/60919/diff/2/
Changes: https://reviews.apache.org/r/60919/diff/1-2/
Testing
-------
Python unit tests passed.
----------------------------------------------------------------------
Total run:1161
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On July 17, 2017, 7:39 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
> > Lines 175-178 (patched)
> > <https://reviews.apache.org/r/60919/diff/1/?file=1777947#file1777947line175>
> >
> > The descriptions says that "if the user has not set custom.hive.warehouse.mode in hive-site" ... But this directive is setting it no matter what, even if it's been configured.
> >
> > Should this instead use the if-present attributes?
Good catch, just fixed it.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/#review180727
-----------------------------------------------------------
On July 17, 2017, 9:31 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60919/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 9:31 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21502
> https://issues.apache.org/jira/browse/AMBARI-21502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
> EU should set the value of custom.hive.warehouse.mode to 0770
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
>
>
> Diff: https://reviews.apache.org/r/60919/diff/2/
>
>
> Testing
> -------
>
> Python unit tests passed.
>
> ----------------------------------------------------------------------
> Total run:1161
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 60919: AMBARI-21502. Cross-stack migration from
BigInsights to HDP,
EU needs to set hive-site custom.hive.warehouse.mode to 0770
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60919/#review180727
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
Lines 175-178 (patched)
<https://reviews.apache.org/r/60919/#comment255946>
The descriptions says that "if the user has not set custom.hive.warehouse.mode in hive-site" ... But this directive is setting it no matter what, even if it's been configured.
Should this instead use the if-present attributes?
- Jonathan Hurley
On July 17, 2017, 3:36 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60919/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 3:36 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21502
> https://issues.apache.org/jira/browse/AMBARI-21502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During cross stack upgrade from BigInsights, if user has not set custom.hive.warehouse.mode in hive-site, as the default value is changed in HDFS from BigInsights default (0770) to HDP default (0777).
> EU should set the value of custom.hive.warehouse.mode to 0770
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml f1a954e
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5f1e06c
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 310e504
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 5b8f8d9
>
>
> Diff: https://reviews.apache.org/r/60919/diff/1/
>
>
> Testing
> -------
>
> Python unit tests passed.
>
> ----------------------------------------------------------------------
> Total run:1161
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>