You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2023/02/20 01:00:57 UTC
[GitHub] [solr] epugh opened a new pull request, #1372: SOLR-16672: Unused setDefaultCollection in SolrCLI
epugh opened a new pull request, #1372:
URL: https://github.com/apache/solr/pull/1372
https://issues.apache.org/jira/browse/SOLR-16672
found unused (I believe!) parameter...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1372: SOLR-16672: Unused setDefaultCollection in SolrCLI
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1372:
URL: https://github.com/apache/solr/pull/1372#issuecomment-1436915316
This turns out to not be an unused config, but instead appears to be used inside of healthcheck, but sort of deeply nested. By moving to an explicit collection parameter, it removes a bit of magic configuration, and does let us remove this at the top... since it's only used in healthcheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1372: SOLR-16672: Remove use of setDefaultCollection in SolrCLI
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1372:
URL: https://github.com/apache/solr/pull/1372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org