You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhongqiangczq (via GitHub)" <gi...@apache.org> on 2023/02/28 07:00:13 UTC
[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1284: CELEBORN-350 [FLINK]Add PluginConf to be compatible with old configur…
zhongqiangczq opened a new pull request, #1284:
URL: https://github.com/apache/incubator-celeborn/pull/1284
…ation keys
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1284: [CELEBORN-350][FLINK]Add PluginConf to be compatible with old configur…
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1284:
URL: https://github.com/apache/incubator-celeborn/pull/1284#discussion_r1119822614
##########
client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGateFactory.java:
##########
@@ -57,20 +59,23 @@ public class RemoteShuffleInputGateFactory {
/** Sum of buffers. */
private final int numBuffersPerGate;
- public static final String MEMORY_PER_INPUT_GATE = "32m";
- public static final String MIN_MEMORY_PER_GATE = "8m";
- public static final int NUM_CONCURRENT_READINGS = Integer.MAX_VALUE;
private CelebornConf celebornConf;
public RemoteShuffleInputGateFactory(
- CelebornConf conf, NetworkBufferPool networkBufferPool, int networkBufferSize) {
+ Configuration flinkConf,
+ CelebornConf conf,
+ NetworkBufferPool networkBufferPool,
+ int networkBufferSize) {
+ this.celebornConf = conf;
long configuredMemorySize =
- org.apache.celeborn.common.util.Utils.byteStringAsBytes(MEMORY_PER_INPUT_GATE);
+ org.apache.celeborn.common.util.Utils.byteStringAsBytes(
+ PluginConf.getValue(flinkConf, PluginConf.MEMORY_PER_INPUT_GATE));
Review Comment:
suggest PluginConf support getStringValueAsBytes function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1284: CELEBORN-350 [FLINK]Add PluginConf to be compatible with old configur…
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1284:
URL: https://github.com/apache/incubator-celeborn/pull/1284#issuecomment-1447689958
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1284?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1284](https://codecov.io/gh/apache/incubator-celeborn/pull/1284?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ac05d94) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/eda21ead2486c587dba7dc63c26b4df24e8fc866?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eda21ea) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ac05d94 differs from pull request most recent head 887284a. Consider uploading reports for the commit 887284a to get more accurate results
```diff
@@ Coverage Diff @@
## main #1284 +/- ##
============================================
+ Coverage 27.13% 27.14% +0.02%
- Complexity 822 823 +1
============================================
Files 215 215
Lines 18459 18459
Branches 1990 1990
============================================
+ Hits 5007 5009 +2
+ Misses 13125 13123 -2
Partials 327 327
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...oy/worker/congestcontrol/CongestionController.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvY29uZ2VzdGNvbnRyb2wvQ29uZ2VzdGlvbkNvbnRyb2xsZXIuamF2YQ==) | `76.20% <0.00%> (-0.95%)` | :arrow_down: |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `77.93% <0.00%> (+1.36%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1284: [CELEBORN-350][FLINK]Add PluginConf to be compatible with old configur…
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1284:
URL: https://github.com/apache/incubator-celeborn/pull/1284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org