You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/07/25 19:44:37 UTC
[GitHub] incubator-brooklyn pull request: add tips for using & abusing RAT
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/97
add tips for using & abusing RAT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn rat-tips
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 004589f3e2e5e356a18988b7dbf7cdee70c5b37d
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-07-25T17:40:13Z
add tips for using & abusing RAT
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add tips for using & abusing RAT
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/97#issuecomment-50183893
More generally than this PR, I would be in favour of Rat only being active when a particular Maven profile ("Pedantic"?) is activated. The profile would be disabled by default but enabled on CI. All pull requests would have the checks run but we avoid the annoyance of builds failing locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add tips for using & abusing RAT
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add tips for using & abusing RAT
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/97#issuecomment-50312541
PR looks good; merging.
+1 to a `fast` profile, and to keeping `rat` in the default profile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add tips for using & abusing RAT
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/97#issuecomment-50184486
@sjcorbett I sympathise but I think we run the risk of merging commits which break RAT if it isn't run by default. However what could be cool is add a `fast` profile which skips making ZIPs and jasmine spec tests and other expensive things, also skipping rat. Build time is going up and up, despite that I'm trying to be aggressive about tests themselves running quickly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---