You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/07 13:26:30 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9483:
[tests] refactor, change datasets and charts to it's own folder
dpgaspar opened a new pull request #9483: [tests] refactor, change datasets and charts to it's own folder
URL: https://github.com/apache/incubator-superset/pull/9483
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [X] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Follow the new structure for tests, and apply it to charts and datasets. Just like in superset base folder, charts and datasets have their own module. Later we should have tests for commands that could be nicely placed here also.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@willbarrett
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed pull request #9483: [tests]
refactor, change datasets and charts to it's own folder
Posted by GitBox <gi...@apache.org>.
dpgaspar closed pull request #9483: [tests] refactor, change datasets and charts to it's own folder
URL: https://github.com/apache/incubator-superset/pull/9483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed pull request #9483: [tests]
refactor, change datasets and charts to it's own folder
Posted by GitBox <gi...@apache.org>.
dpgaspar closed pull request #9483: [tests] refactor, change datasets and charts to it's own folder
URL: https://github.com/apache/incubator-superset/pull/9483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9483: [tests]
refactor, change datasets and charts to it's own folder
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9483: [tests] refactor, change datasets and charts to it's own folder
URL: https://github.com/apache/incubator-superset/pull/9483#issuecomment-610595728
@dpgaspar did you mean to close this without merging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9483:
[tests] refactor, change datasets and charts to it's own folder
Posted by GitBox <gi...@apache.org>.
dpgaspar opened a new pull request #9483: [tests] refactor, change datasets and charts to it's own folder
URL: https://github.com/apache/incubator-superset/pull/9483
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [X] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Follow the new structure for tests, and apply it to charts and datasets. Just like in superset base folder, charts and datasets have their own module. Later we should have tests for commands that could be nicely placed here also.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@willbarrett
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org