You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dmitry Zhuk <dz...@twopensource.com> on 2017/07/17 11:41:55 UTC
Re: Review Request 60002: Added ENUM preprocessor macro.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60002/
-----------------------------------------------------------
(Updated July 17, 2017, 11:41 a.m.)
Review request for mesos, Benjamin Hindman, haosdent huang, James Peach, and Michael Park.
Summary (updated)
-----------------
Added ENUM preprocessor macro.
Bugs: MESOS-7713
https://issues.apache.org/jira/browse/MESOS-7713
Repository: mesos
Description (updated)
-------
This allows using templates to generate parameters lists, for example:
#define MOVE_TEMPLATE(Z, N, DATA) std::move(DATA ## N)
Then it can be used as
call(ENUM(2, MOVE_TEMPLATE, p));
which is expanded as
call(std::move(p1), std::move(p2));
Diffs (updated)
-----
3rdparty/stout/include/stout/preprocessor.hpp 48d63318712d454b118db64af11c694da92bca6a
Diff: https://reviews.apache.org/r/60002/diff/2/
Changes: https://reviews.apache.org/r/60002/diff/1-2/
Testing
-------
Thanks,
Dmitry Zhuk
Re: Review Request 60002: Added ENUM preprocessor macro.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60002/#review181719
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On July 17, 2017, 4:41 a.m., Dmitry Zhuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60002/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 4:41 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, haosdent huang, James Peach, and Michael Park.
>
>
> Bugs: MESOS-7713
> https://issues.apache.org/jira/browse/MESOS-7713
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows using templates to generate parameters lists, for example:
> #define MOVE_TEMPLATE(Z, N, DATA) std::move(DATA ## N)
>
> Then it can be used as
> call(ENUM(2, MOVE_TEMPLATE, p));
> which is expanded as
> call(std::move(p1), std::move(p2));
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/preprocessor.hpp 48d63318712d454b118db64af11c694da92bca6a
>
>
> Diff: https://reviews.apache.org/r/60002/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitry Zhuk
>
>