You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Robert Muir <rc...@gmail.com> on 2009/12/28 21:02:51 UTC
Re: svn commit: r894224 - in /lucene/java/trunk/contrib:
benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/
highlighter/src/java/org/apache/lucene/search/highlight/ instantiated/src/java/org/apache/lucene/store/instantiated/
Simon, are we sure these are spelling issues, I think this iff stands
for 'if and only if' in these cases?
http://en.wikipedia.org/wiki/If_and_only_if
On Mon, Dec 28, 2009 at 1:52 PM, <si...@apache.org> wrote:
> Author: simonw
> Date: Mon Dec 28 18:52:19 2009
> New Revision: 894224
>
> URL: http://svn.apache.org/viewvc?rev=894224&view=rev
> Log:
> fixed trivial spelling issues in javadoc
>
> Modified:
> lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
> lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
> lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
>
> Modified: lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
> URL: http://svn.apache.org/viewvc/lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java?rev=894224&r1=894223&r2=894224&view=diff
> ==============================================================================
> --- lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java (original)
> +++ lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java Mon Dec 28 18:52:19 2009
> @@ -287,7 +287,7 @@
>
> /**
> * Sub classes that supports parameters must override this method to return true.
> - * @return true iff this task supports command line params.
> + * @return true if this task supports command line params.
> */
> public boolean supportsParams () {
> return false;
>
> Modified: lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
> URL: http://svn.apache.org/viewvc/lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java?rev=894224&r1=894223&r2=894224&view=diff
> ==============================================================================
> --- lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java (original)
> +++ lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java Mon Dec 28 18:52:19 2009
> @@ -53,8 +53,8 @@
> * Checks to see if this term is valid at <code>position</code>.
> *
> * @param position
> - * to check against valid term postions
> - * @return true iff this term is a hit at this position
> + * to check against valid term positions
> + * @return true if this term is a hit at this position
> */
> public boolean checkPosition(int position) {
> // There would probably be a slight speed improvement if PositionSpans
>
> Modified: lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
> URL: http://svn.apache.org/viewvc/lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java?rev=894224&r1=894223&r2=894224&view=diff
> ==============================================================================
> --- lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java (original)
> +++ lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java Mon Dec 28 18:52:19 2009
> @@ -80,7 +80,7 @@
>
> /**
> * Skips entries to the first beyond the current whose document number is
> - * greater than or equal to <currentTermPositionIndex>target</currentTermPositionIndex>. <p>Returns true iff there is such
> + * greater than or equal to <currentTermPositionIndex>target</currentTermPositionIndex>. <p>Returns true if there is such
> * an entry. <p>Behaves as if written: <pre>
> * boolean skipTo(int target) {
> * do {
>
>
>
--
Robert Muir
rcmuir@gmail.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: svn commit: r894224 - in /lucene/java/trunk/contrib:
benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/
highlighter/src/java/org/apache/lucene/search/highlight/ instantiated/src/java/org/apache/lucene/store/instantiated/
Posted by Simon Willnauer <si...@googlemail.com>.
Sorry about that - never really noticed that abbreviation as if and ...
I reverted the s/iff/if changes. Thanks for picking this up robert.
simon
On Mon, Dec 28, 2009 at 11:26 PM, Erick Erickson
<er...@gmail.com> wrote:
> I once knew of a math prof in the early days of electronic
> book submissions who had a helpful person change all the
> "iff"s into "if" thinking they were all typo's... in all the proofs
> in a math text... As his fellow faculty member was relaying
> the story added "putting them back was non-trivial"....
>
> Erick
>
> On Mon, Dec 28, 2009 at 3:02 PM, Robert Muir <rc...@gmail.com> wrote:
>>
>> Simon, are we sure these are spelling issues, I think this iff stands
>> for 'if and only if' in these cases?
>>
>> http://en.wikipedia.org/wiki/If_and_only_if
>>
>> On Mon, Dec 28, 2009 at 1:52 PM, <si...@apache.org> wrote:
>> > Author: simonw
>> > Date: Mon Dec 28 18:52:19 2009
>> > New Revision: 894224
>> >
>> > URL: http://svn.apache.org/viewvc?rev=894224&view=rev
>> > Log:
>> > fixed trivial spelling issues in javadoc
>> >
>> > Modified:
>> >
>> > lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
>> >
>> > lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
>> >
>> > lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
>> >
>> > Modified:
>> > lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
>> > URL:
>> > http://svn.apache.org/viewvc/lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java?rev=894224&r1=894223&r2=894224&view=diff
>> >
>> > ==============================================================================
>> > ---
>> > lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
>> > (original)
>> > +++
>> > lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
>> > Mon Dec 28 18:52:19 2009
>> > @@ -287,7 +287,7 @@
>> >
>> > /**
>> > * Sub classes that supports parameters must override this method to
>> > return true.
>> > - * @return true iff this task supports command line params.
>> > + * @return true if this task supports command line params.
>> > */
>> > public boolean supportsParams () {
>> > return false;
>> >
>> > Modified:
>> > lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
>> > URL:
>> > http://svn.apache.org/viewvc/lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java?rev=894224&r1=894223&r2=894224&view=diff
>> >
>> > ==============================================================================
>> > ---
>> > lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
>> > (original)
>> > +++
>> > lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
>> > Mon Dec 28 18:52:19 2009
>> > @@ -53,8 +53,8 @@
>> > * Checks to see if this term is valid at <code>position</code>.
>> > *
>> > * @param position
>> > - * to check against valid term postions
>> > - * @return true iff this term is a hit at this position
>> > + * to check against valid term positions
>> > + * @return true if this term is a hit at this position
>> > */
>> > public boolean checkPosition(int position) {
>> > // There would probably be a slight speed improvement if
>> > PositionSpans
>> >
>> > Modified:
>> > lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
>> > URL:
>> > http://svn.apache.org/viewvc/lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java?rev=894224&r1=894223&r2=894224&view=diff
>> >
>> > ==============================================================================
>> > ---
>> > lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
>> > (original)
>> > +++
>> > lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
>> > Mon Dec 28 18:52:19 2009
>> > @@ -80,7 +80,7 @@
>> >
>> > /**
>> > * Skips entries to the first beyond the current whose document number
>> > is
>> > - * greater than or equal to
>> > <currentTermPositionIndex>target</currentTermPositionIndex>. <p>Returns true
>> > iff there is such
>> > + * greater than or equal to
>> > <currentTermPositionIndex>target</currentTermPositionIndex>. <p>Returns true
>> > if there is such
>> > * an entry. <p>Behaves as if written: <pre>
>> > * boolean skipTo(int target) {
>> > * do {
>> >
>> >
>> >
>>
>>
>>
>> --
>> Robert Muir
>> rcmuir@gmail.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: svn commit: r894224 - in /lucene/java/trunk/contrib:
benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/
highlighter/src/java/org/apache/lucene/search/highlight/ instantiated/src/java/org/apache/lucene/store/instantiated/
Posted by Erick Erickson <er...@gmail.com>.
I once knew of a math prof in the early days of electronic
book submissions who had a helpful person change all the
"iff"s into "if" thinking they were all typo's... in all the proofs
in a math text... As his fellow faculty member was relaying
the story added "putting them back was non-trivial"....
Erick
On Mon, Dec 28, 2009 at 3:02 PM, Robert Muir <rc...@gmail.com> wrote:
> Simon, are we sure these are spelling issues, I think this iff stands
> for 'if and only if' in these cases?
>
> http://en.wikipedia.org/wiki/If_and_only_if
>
> On Mon, Dec 28, 2009 at 1:52 PM, <si...@apache.org> wrote:
> > Author: simonw
> > Date: Mon Dec 28 18:52:19 2009
> > New Revision: 894224
> >
> > URL: http://svn.apache.org/viewvc?rev=894224&view=rev
> > Log:
> > fixed trivial spelling issues in javadoc
> >
> > Modified:
> >
> lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
> >
> lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
> >
> lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
> >
> > Modified:
> lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
> > URL:
> http://svn.apache.org/viewvc/lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java?rev=894224&r1=894223&r2=894224&view=diff
> >
> ==============================================================================
> > ---
> lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
> (original)
> > +++
> lucene/java/trunk/contrib/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/PerfTask.java
> Mon Dec 28 18:52:19 2009
> > @@ -287,7 +287,7 @@
> >
> > /**
> > * Sub classes that supports parameters must override this method to
> return true.
> > - * @return true iff this task supports command line params.
> > + * @return true if this task supports command line params.
> > */
> > public boolean supportsParams () {
> > return false;
> >
> > Modified:
> lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
> > URL:
> http://svn.apache.org/viewvc/lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java?rev=894224&r1=894223&r2=894224&view=diff
> >
> ==============================================================================
> > ---
> lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
> (original)
> > +++
> lucene/java/trunk/contrib/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTerm.java
> Mon Dec 28 18:52:19 2009
> > @@ -53,8 +53,8 @@
> > * Checks to see if this term is valid at <code>position</code>.
> > *
> > * @param position
> > - * to check against valid term postions
> > - * @return true iff this term is a hit at this position
> > + * to check against valid term positions
> > + * @return true if this term is a hit at this position
> > */
> > public boolean checkPosition(int position) {
> > // There would probably be a slight speed improvement if
> PositionSpans
> >
> > Modified:
> lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
> > URL:
> http://svn.apache.org/viewvc/lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java?rev=894224&r1=894223&r2=894224&view=diff
> >
> ==============================================================================
> > ---
> lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
> (original)
> > +++
> lucene/java/trunk/contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermPositions.java
> Mon Dec 28 18:52:19 2009
> > @@ -80,7 +80,7 @@
> >
> > /**
> > * Skips entries to the first beyond the current whose document number
> is
> > - * greater than or equal to
> <currentTermPositionIndex>target</currentTermPositionIndex>. <p>Returns true
> iff there is such
> > + * greater than or equal to
> <currentTermPositionIndex>target</currentTermPositionIndex>. <p>Returns true
> if there is such
> > * an entry. <p>Behaves as if written: <pre>
> > * boolean skipTo(int target) {
> > * do {
> >
> >
> >
>
>
>
> --
> Robert Muir
> rcmuir@gmail.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>