You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Paul Elschot (JIRA)" <ji...@apache.org> on 2008/10/06 19:43:44 UTC
[jira] Issue Comment Edited: (LUCENE-1410) PFOR implementation
[ https://issues.apache.org/jira/browse/LUCENE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637149#action_12637149 ]
paul.elschot@xs4all.nl edited comment on LUCENE-1410 at 10/6/08 10:43 AM:
----------------------------------------------------------------
I can't see the .tgz attachment at the moment.
Very nice table, this java/c++ comparison. Meanwhile I also have a java program generator for decompression, and I got very similar results.
I found a bug for the 17 bits case in decodeAnyFrame(), this might explain the sum test failure that you saw.
One detail on the generated code: the final mask can be omitted, for example the last bit extraction for the 5 bit case:
{code} (i4 >>> 27)
{code}
On the java side leaving this last mask out did not make a difference, but it might be noticeable in c++.
was (Author: paul.elschot@xs4all.nl):
I can't see the .tgz attachment at the moment.
Very nice table, this java/c++ comparison. Meanwhile I also have a java program generator for decompression, and I got very similar results.
I found a bug for the 17 bits case in decodeAnyFrame(), this might explain the sum test failure that you saw.
One detail on the generated code: the final mask can be omitted, for example the last bit extraction for the 5 bit case:
.bq (i4 >>> 27)
On the java side leaving this last mask out did not make a difference, but it might be noticeable in c++.
> PFOR implementation
> -------------------
>
> Key: LUCENE-1410
> URL: https://issues.apache.org/jira/browse/LUCENE-1410
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Other
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: LUCENE-1410b.patch, TestPFor2.java, TestPFor2.java, TestPFor2.java
>
> Original Estimate: 21840h
> Remaining Estimate: 21840h
>
> Implementation of Patched Frame of Reference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org