You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Doug MacEachern <do...@covalent.net> on 2001/08/20 23:29:35 UTC
ldap?
hi, why are there ldap modules in the httpd-2.0 tree?
Re: ldap?
Posted by Graham Leggett <mi...@sharp.fm>.
Ryan Bloom wrote:
> Woah. Those are build differences, not C-code differences. Those can
> all be handled with some simple m4 configure scripts. Why are we wrapping
> C-code? What differences are we abstracting with the C code?
The C differences are involved with standardising between some
differences between LDAP v2.0, and v3.0 and how they are implemented in
some libraries (some functions are missing).
Slowly though I am thinking that this belongs in the mod_ldap module
itself, and not apr-util. This way when mod_ldap is enabled and built,
it drags in with it the LDAP library, but not otherwise. LDAP in
apr-util made sense when the idea was to add LDAP based config files to
the core, but since that's been moved to a preprocessor idea suddenly
there is less need.
I think the exact same thing is done with mod_ssl.
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: ldap?
Posted by sterling <st...@covalent.net>.
Exactly -
It would be one thing if each library had a lot of non-standard calls
(i.e. different functions) that performed generally the same tasks - but
that is not what is happening here.
sterling
On Tue, 21 Aug 2001, Ryan Bloom wrote:
>
> Woah. Those are build differences, not C-code differences. Those can
> all be handled with some simple m4 configure scripts. Why are we wrapping
> C-code? What differences are we abstracting with the C code?
>
> Ryan
>
> On Tuesday 21 August 2001 11:54, Graham Leggett wrote:
> > sterling wrote:
> > > > Well, it did have a portability function in that it smoothed out
> > > > differences between various LDAP libraries (openldap/netscape/iplanet)
> > > > rather than various platforms (unix/nt/etc).
> > >
> > > what differences are smoothed out? maybe i'm looking in the wrong place,
> > > but i don't see any of this functionality.
> >
> > Openldap:
> >
> > - uses ldap.h, lber.h
> > - links to libldap and liblber
> > - supports STARTTLS
> >
> > Netscape
> >
> > - uses ldap.h, lber.h, ldap_ssl.h
> > - links to libldapssl(20|30|40|41)
> > - supports SSL, but not TLS
> >
> > iPlanet
> >
> > - header files???
> > - links to libldap50 and these: "-lnspr4 -lplc4 -lplds4 -liutil50
> > -llber50 -lldif50 -lnss3 -lprldap50 -lssl3 -lssldap50"
> > - SSL support, TLS support unknown
> >
> > Active Directory
> >
> > - ???
> >
> > In addition there are a whole bunch of differences depending on whether
> > you're using LDAP v2.0 or v3.0 - see apr_ldap_compat.c.
> >
> > Regards,
> > Graham
>
> ----------------------------------------
> Content-Type: application/x-pkcs7-signature; charset="us-ascii"; name="smime.p7s"
> Content-Transfer-Encoding: base64
> Content-Description: S/MIME Cryptographic Signature
> ----------------------------------------
>
>
Re: ldap?
Posted by Ryan Bloom <rb...@covalent.net>.
Woah. Those are build differences, not C-code differences. Those can
all be handled with some simple m4 configure scripts. Why are we wrapping
C-code? What differences are we abstracting with the C code?
Ryan
On Tuesday 21 August 2001 11:54, Graham Leggett wrote:
> sterling wrote:
> > > Well, it did have a portability function in that it smoothed out
> > > differences between various LDAP libraries (openldap/netscape/iplanet)
> > > rather than various platforms (unix/nt/etc).
> >
> > what differences are smoothed out? maybe i'm looking in the wrong place,
> > but i don't see any of this functionality.
>
> Openldap:
>
> - uses ldap.h, lber.h
> - links to libldap and liblber
> - supports STARTTLS
>
> Netscape
>
> - uses ldap.h, lber.h, ldap_ssl.h
> - links to libldapssl(20|30|40|41)
> - supports SSL, but not TLS
>
> iPlanet
>
> - header files???
> - links to libldap50 and these: "-lnspr4 -lplc4 -lplds4 -liutil50
> -llber50 -lldif50 -lnss3 -lprldap50 -lssl3 -lssldap50"
> - SSL support, TLS support unknown
>
> Active Directory
>
> - ???
>
> In addition there are a whole bunch of differences depending on whether
> you're using LDAP v2.0 or v3.0 - see apr_ldap_compat.c.
>
> Regards,
> Graham
----------------------------------------
Content-Type: application/x-pkcs7-signature; charset="us-ascii"; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Description: S/MIME Cryptographic Signature
----------------------------------------
--
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: ldap?
Posted by Graham Leggett <mi...@sharp.fm>.
sterling wrote:
> > Well, it did have a portability function in that it smoothed out
> > differences between various LDAP libraries (openldap/netscape/iplanet)
> > rather than various platforms (unix/nt/etc).
>
> what differences are smoothed out? maybe i'm looking in the wrong place,
> but i don't see any of this functionality.
Openldap:
- uses ldap.h, lber.h
- links to libldap and liblber
- supports STARTTLS
Netscape
- uses ldap.h, lber.h, ldap_ssl.h
- links to libldapssl(20|30|40|41)
- supports SSL, but not TLS
iPlanet
- header files???
- links to libldap50 and these: "-lnspr4 -lplc4 -lplds4 -liutil50
-llber50 -lldif50 -lnss3 -lprldap50 -lssl3 -lssldap50"
- SSL support, TLS support unknown
Active Directory
- ???
In addition there are a whole bunch of differences depending on whether
you're using LDAP v2.0 or v3.0 - see apr_ldap_compat.c.
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: ldap?
Posted by sterling <st...@covalent.net>.
On Tue, 21 Aug 2001, Graham Leggett wrote:
> Ryan Bloom wrote:
>
> > No. That is where we started from. Graham sent a large patch that did all
> > of this, but a lot of it didn't really belong in APR or APR-util, because
> > it had nothing to do with portability.
>
> Well, it did have a portability function in that it smoothed out
> differences between various LDAP libraries (openldap/netscape/iplanet)
> rather than various platforms (unix/nt/etc).
what differences are smoothed out? maybe i'm looking in the wrong place,
but i don't see any of this functionality.
sterling
Re: ldap?
Posted by Graham Leggett <mi...@sharp.fm>.
Ryan Bloom wrote:
> No. That is where we started from. Graham sent a large patch that did all
> of this, but a lot of it didn't really belong in APR or APR-util, because
> it had nothing to do with portability.
Well, it did have a portability function in that it smoothed out
differences between various LDAP libraries (openldap/netscape/iplanet)
rather than various platforms (unix/nt/etc).
> Based on the number of problems we have
> had figuring out where this code belongs, there is a BIG part of me that thinks it
> probably doesn't belong as a part of httpd. Either the ASF should create an ldap
> project, or perhaps this should just be contributed to openldap.
It would make no sense in openldap, because the point of the code is to
allow native LDAP libraries to be used other than openldap. In fact the
shared memory cache code was introduced due to broken/missing cache
functionality in some of the LDAP libraries.
> I don't
> really have an answer, I'm just trying to figure out the best solution.
I think an ldap subproject is the answer. Then we can argue whether the
LDAP extension to mod_proxy belongs in the proxy subproject, or the ldap
subproject :)
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: ldap?
Posted by Ryan Bloom <rb...@covalent.net>.
> [About mod_ldap - if it accomplishes nothing (standing alone) yet is very
> useful functionallity, it really does deserve it's own apr-ldap
> repository.]
No. That is where we started from. Graham sent a large patch that did all
of this, but a lot of it didn't really belong in APR or APR-util, because
it had nothing to do with portability. Based on the number of problems we have
had figuring out where this code belongs, there is a BIG part of me that thinks it
probably doesn't belong as a part of httpd. Either the ASF should create an ldap
project, or perhaps this should just be contributed to openldap. I don't
really have an answer, I'm just trying to figure out the best solution.
> pps - it would be really nice to have a single checkout called httpd-all
> that grabs everything, wouldn't it :-?
Agreed.
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: ldap?
Posted by Ryan Bloom <rb...@covalent.net>.
\
> [About mod_ldap - if it accomplishes nothing (standing alone) yet is very
> useful functionallity, it really does deserve it's own apr-ldap
> repository.]
>
> pps - it would be really nice to have a single checkout called httpd-all
> that grabs everything, wouldn't it :-?
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: ldap?
Posted by Graham Leggett <mi...@sharp.fm>.
"William A. Rowe, Jr." wrote:
> No, please move it first. This creates four communities (proxy, pop, mbox,
> and ldap) that all share a desire to get this resolved. A fifth is likely
> on it's way - there are users in some parts of the world that cannot *legally*
> download or checkout httpd without violating the crypto laws of their own
> country. So let's say five communities. So tls/ssl will likely move into
> an httpd-ssl [or -tls, I don't care] project.
Ok - so let's move both mod_tls and mod_ldap* now, and then get the
rollup release procedure finalised now - then it's done.
Who can do this?
> pps - it would be really nice to have a single checkout called httpd-all that
> grabs everything, wouldn't it :-?
That would be very useful for the end user. So far what's making things
easier for us over time has been making it harder for end users...
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: ldap?
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
From: "Graham Leggett" <mi...@sharp.fm>
Sent: Monday, August 20, 2001 11:25 PM
> Ryan Bloom wrote:
>
> > I realize that this is a small piece, but the message posted by Will
> > also doesn't say anything about mod_auth_ldap.c.
>
> mod_auth_ldap is that part of the LDAP patch that does the actual useful
> work (mod_ldap does nothing useful on it's own). I put it in modules/aaa
> because I felt it made the most sense there, though there is no reason
> it couldn't be in modules/ldap.
> > > why wasn't an httpd-ldap or similar subproject created for this instead?
>
> This is not a bad idea - though I think it is important to see the issue
> of the Apache rollup release resolved before it gets moved.
No, please move it first. This creates four communities (proxy, pop, mbox,
and ldap) that all share a desire to get this resolved. A fifth is likely
on it's way - there are users in some parts of the world that cannot *legally*
download or checkout httpd without violating the crypto laws of their own
country. So let's say five communities. So tls/ssl will likely move into
an httpd-ssl [or -tls, I don't care] project.
The mod_ldap/mod_auth_ldap don't implement any aspect of the http protocol,
so they need to be located in a subproject (heck, proxy implements a huge
subset of the http protocol, yet it's broken out to accomplish it's own
development track.)
> There are some dependancy relationships that are starting to form
> between the various modules - mod_proxy will soon depend on mod_tls and
> mod_ldap, mod_auth_ldap depends on mod_ldap. We need to make sure that
> the rollup tree has all the modules that satisfy the dependancies in
> one.
There always were. That's what the family of hooks, registered functions,
callbacks and pool notes come in.
Bill
[About mod_ldap - if it accomplishes nothing (standing alone) yet is very
useful functionallity, it really does deserve it's own apr-ldap repository.]
pps - it would be really nice to have a single checkout called httpd-all that
grabs everything, wouldn't it :-?
Re: ldap?
Posted by Graham Leggett <mi...@sharp.fm>.
Ryan Bloom wrote:
> I realize that this is a small piece, but the message posted by Will
> also doesn't say anything about mod_auth_ldap.c.
mod_auth_ldap is that part of the LDAP patch that does the actual useful
work (mod_ldap does nothing useful on it's own). I put it in modules/aaa
because I felt it made the most sense there, though there is no reason
it couldn't be in modules/ldap. It was posted along with the final
version of the patch last week, and I commited it after the mod_ldap
commit having received no objections.
> > why wasn't an httpd-ldap or similar subproject created for this instead?
This is not a bad idea - though I think it is important to see the issue
of the Apache rollup release resolved before it gets moved.
There are some dependancy relationships that are starting to form
between the various modules - mod_proxy will soon depend on mod_tls and
mod_ldap, mod_auth_ldap depends on mod_ldap. We need to make sure that
the rollup tree has all the modules that satisfy the dependancies in
one.
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: ldap?
Posted by Ryan Bloom <rb...@covalent.net>.
I realize that this is a small piece, but the message posted by Will
also doesn't say anything about mod_auth_ldap.c.
Ryan
On Monday 20 August 2001 16:13, Doug MacEachern wrote:
> my concern is adding new modules this late in the game, especially
> something with size:
> % find . -name '*ldap*.[ch]' | xargs wc -l
> 286 ./include/util_ldap.h
> 828 ./modules/aaa/mod_auth_ldap.c
> 1077 ./modules/ldap/util_ldap.c
> 248 ./modules/ldap/util_ldap_cache.c
> 213 ./modules/ldap/util_ldap_cache.h
> 529 ./modules/ldap/util_ldap_cache_mgr.c
> 100 ./srclib/apr-util/ldap/apr_ldap_compat.c
> 112 ./srclib/apr-util/include/apr_ldap.h
> 3393 total
>
> why wasn't an httpd-ldap or similar subproject created for this instead?
--
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: ldap?
Posted by Doug MacEachern <do...@covalent.net>.
my concern is adding new modules this late in the game, especially
something with size:
% find . -name '*ldap*.[ch]' | xargs wc -l
286 ./include/util_ldap.h
828 ./modules/aaa/mod_auth_ldap.c
1077 ./modules/ldap/util_ldap.c
248 ./modules/ldap/util_ldap_cache.c
213 ./modules/ldap/util_ldap_cache.h
529 ./modules/ldap/util_ldap_cache_mgr.c
100 ./srclib/apr-util/ldap/apr_ldap_compat.c
112 ./srclib/apr-util/include/apr_ldap.h
3393 total
why wasn't an httpd-ldap or similar subproject created for this instead?
Re: ldap?
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
From: "Doug MacEachern" <do...@covalent.net>
Sent: Monday, August 20, 2001 4:29 PM
>
> hi, why are there ldap modules in the httpd-2.0 tree?
----- Original Message -----
From: "Ryan Bloom" <rb...@covalent.net>
To: "Graham Leggett" <mi...@sharp.fm>; <rb...@covalent.net>
Cc: "Justin Erenkrantz" <je...@ebuilt.com>; <de...@apr.apache.org>
Sent: Monday, August 13, 2001 5:59 PM
Subject: Re: [PATCH] LDAP extension to apr-util (take 2)
>
> Now this I can get behind.
>
> On Monday 13 August 2001 13:37, Graham Leggett wrote:
> > Ryan Bloom wrote:
> > > Then this is the only thing that should be in apr_ldap. If we are trying
> > > to create a wrapper library to abstract out differences in all of the
> > > other LDAP libraries, then I _might_ be able to get behind that.
> >
> > Ok.
> >
> > > None of that stuff belongs in apr-util. This has nothing to do with
> > > portability, this has to do with attaching LDAP to a web server. If this
> > > is something that we want to provide as a standard part of Apache, not
> > > sure we do (haven't thought about it much), then it should be a part of
> > > the module that attaches the two together, not a part of the abstraction
> > > library.
> >
> > So this should be part of Apache - now for the next question - should it
> > be an Apache module, or part of the Apache core?
> >
> > > If these routines are not meant to be an abstraction layer for all LDAP
> > > libraries, then they do not belong in APR or APR-util.
> >
> > Ok, I propose this:
> >
> > - The linking-to-miriad-of-different-ldap-libraries function, and the
> > small bit in apr_ldap_compat.c that smooths out differences between
> > functions in LDAP v2 and v3 should go in APR-util (or APR?). (This patch
> > is small and easy to review.)
>
> +1
>
> >
> > - The LDAP connection-reuse / compare cache should be abstracted into
> > their own module in the Apache tree (under modules/ldap/) that provides
> > additional LDAP services to modules that need them.
>
> +1
>
> Ryan
----- Original Message -----
From: "Justin Erenkrantz" <je...@ebuilt.com>
To: "Graham Leggett" <mi...@sharp.fm>
Cc: <rb...@covalent.net>; <de...@apr.apache.org>
Sent: Monday, August 13, 2001 5:46 PM
Subject: Re: [PATCH] LDAP extension to apr-util (take 2)
> On Mon, Aug 13, 2001 at 10:37:33PM +0200, Graham Leggett wrote:
> > - The linking-to-miriad-of-different-ldap-libraries function, and the
> > small bit in apr_ldap_compat.c that smooths out differences between
> > functions in LDAP v2 and v3 should go in APR-util (or APR?). (This patch
> > is small and easy to review.)
>
> ++1.
>
> > - The LDAP connection-reuse / compare cache should be abstracted into
> > their own module in the Apache tree (under modules/ldap/) that provides
> > additional LDAP services to modules that need them.
>
> +1. -- justin
----- Original Message -----
From: "Roy T. Fielding" <fi...@ebuilt.com>
To: "Graham Leggett" <mi...@sharp.fm>
Cc: <rb...@covalent.net>; "Justin Erenkrantz" <je...@ebuilt.com>; <de...@apr.apache.org>
Sent: Monday, August 13, 2001 5:43 PM
Subject: Re: [PATCH] LDAP extension to apr-util (take 2)
> > Ok, I propose this:
> >
> > - The linking-to-miriad-of-different-ldap-libraries function, and the
> > small bit in apr_ldap_compat.c that smooths out differences between
> > functions in LDAP v2 and v3 should go in APR-util (or APR?). (This patch
> > is small and easy to review.)
>
> +1
>
> > - The LDAP connection-reuse / compare cache should be abstracted into
> > their own module in the Apache tree (under modules/ldap/) that provides
> > additional LDAP services to modules that need them.
>
> +1
>
> ....Roy