You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/06/10 12:09:10 UTC

[GitHub] [skywalking-java] ForestWang123 commented on a diff in pull request #194: Fix argument type name in postgresql plugin and add type name checking

ForestWang123 commented on code in PR #194:
URL: https://github.com/apache/skywalking-java/pull/194#discussion_r894453492


##########
apm-sniffer/apm-sdk-plugin/postgresql-8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/postgresql/define/PgStatementInstrumentation.java:
##########
@@ -43,12 +43,8 @@ public InstanceMethodsInterceptPoint[] getInstanceMethodsInterceptPoints() {
             new InstanceMethodsInterceptPoint() {
                 @Override
                 public ElementMatcher<MethodDescription> getMethodsMatcher() {
-                    return named("execute").and(takesArgumentWithType(0, "java.lang.String"))
-                                           .or(named("execute").and(takesArgumentWithType(0, "java.lang.String[]")))

Review Comment:
   OK, There are some problems of my implementation here.  
   I have tightened the matching rule for execute and executeUpdate; delete the executeLargeUpdate methods which have not been implemented in PgStatement.
   
   Please check, thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org