[GitHub] [flink] liyafan82 commented on a change in pull request #8483: [FLINK-12553][Table SQL / Runtime]Fix a bug in SqlDateTimeUtils#parseToTimeMillis

[GitBox <gi...@apache.org>]

liyafan82 commented on a change in pull request #8483: [FLINK-12553][Table SQL / Runtime]Fix a bug in SqlDateTimeUtils#parseToTimeMillis
URL: https://github.com/apache/flink/pull/8483#discussion_r285481621
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/functions/SqlDateTimeUtilsTest.java
 ##########
 @@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.	See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.	You may obtain a copy of the License at
+ *
+ *		http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.functions;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.lang.reflect.Method;
+import java.util.TimeZone;
+
+import static org.apache.zookeeper.server.ServerCnxn.me;
+
+/**
+ * Test cases for class {@link SqlDateTimeUtils}.
+ */
+public class SqlDateTimeUtilsTest {
 
 Review comment:
   Sure. Thanks 
   
   > > Fix a bug in SqlDateTimeUtils#parseToTimeMillis: If parameter "1999-12-31 12:34:56.123" is used, it should return 123. But it returns 230 now.
   > 
   > It is 230 not 1230?
   
   It should be 1230. Thanks for your careful review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services