You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/19 05:35:51 UTC
[GitHub] [skywalking-agent-test-tool] nisiyong opened a new pull request, #49: Support string operators `start with` and `end with`
nisiyong opened a new pull request, #49:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/49
* Support new string operators `start with` and `end with`
* Introduce the enum ExpressOperator to refactor ExpressParser
* Add space for operator prefix to fix https://github.com/apache/skywalking-agent-test-tool/pull/47
* Add meterItems test case
And https://github.com/apache/skywalking-java/pull/387 all tests are passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] nisiyong commented on a diff in pull request #49: Support string operators `start with` and `end with`
Posted by GitBox <gi...@apache.org>.
nisiyong commented on code in PR #49:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/49#discussion_r1027044737
##########
validator/src/main/java/org/apache/skywalking/plugin/test/agent/tool/validator/assertor/ExpressOperator.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.skywalking.plugin.test.agent.tool.validator.assertor;
+
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+
+@Getter
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public enum ExpressOperator {
+ NULL("null", false),
+ NOT_NULL("not null", false),
+ NOT_BLANK("not blank", false),
+ NOT_EQUALS("nq ",true),
+ EQUALS("eq ",true),
+ GREAT_THAN("gt ",true),
+ GREAT_EQUAL("ge ",true),
Review Comment:
@wu-sheng In previous PR, there is no space at prefix., like this `GREAT_EQUAL("ge",true),`, so the value `get` will match failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on pull request #49: Support string operators `start with` and `end with`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #49:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/49#issuecomment-1320810291
Could you explain how the previous change made the bug? And how you avoid it this time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng merged pull request #49: Support string operators `start with` and `end with`
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #49:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org