You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by beyond1920 <gi...@git.apache.org> on 2017/01/24 06:39:45 UTC
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3196
[FLINK-5566] [Table API & SQL]Introduce structure to hold table and column level statistics
This pr aims to introduce structure to hold table and column level statistics.
TableStats\uff1a Responsible for hold table level statistics
ColumnStats: Responsible for hold column level statistics.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alibaba/flink flink-5566
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3196
----
commit cadc16eefb0e0a9002e536a48b4b9f6824b6ab23
Author: \u69ff\u745c <ji...@alibaba-inc.com>
Date: 2017-01-24T06:34:01Z
Introduce structure to hold table and column level statistics
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100851670
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.stats
+
+/**
+ * column statistics
+ *
+ * @param ndv number of distinct values
+ * @param nullCount number of nulls
+ * @param avgLen average length of column values
+ * @param maxLen max length of column values
+ * @param max max value of column values
+ * @param min min value of column values
+ */
+case class ColumnStats(
+ ndv: Long,
+ nullCount: Long,
+ avgLen: Long,
--- End diff --
I think `Int` should be sufficient for value length.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
Posted by beyond1920 <gi...@git.apache.org>.
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100951579
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.stats
+
+/**
+ * column statistics
+ *
+ * @param ndv number of distinct values
+ * @param nullCount number of nulls
+ * @param avgLen average length of column values
+ * @param maxLen max length of column values
+ * @param max max value of column values
+ * @param min min value of column values
+ */
+case class ColumnStats(
+ ndv: Long,
+ nullCount: Long,
+ avgLen: Long,
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
Posted by beyond1920 <gi...@git.apache.org>.
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100958745
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.stats
+
+/**
+ * column statistics
+ *
+ * @param ndv number of distinct values
+ * @param nullCount number of nulls
+ * @param avgLen average length of column values
+ * @param maxLen max length of column values
+ * @param max max value of column values
+ * @param min min value of column values
+ */
+case class ColumnStats(
+ ndv: Long,
+ nullCount: Long,
+ avgLen: Long,
+ maxLen: Long,
+ max: Option[Any],
+ min: Option[Any]) {
--- End diff --
It makes sense to add a field to denote whether stats are precise or approximate and a field to hold timestamp when the stats were generated. But I'm not sure how these two fields effects the optimized plan. Because we prefer to use the provided stats, even it is estimated value or it is a little stale. So I didn't add these two fields currently, maybe will add them later. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3196: [FLINK-5566] [Table API & SQL]Introduce structure to hold...
Posted by beyond1920 <gi...@git.apache.org>.
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3196
@fhueske , thanks for your review. I modify code based on your advice, including compatibility with Java and column stats field type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3196: [FLINK-5566] [Table API & SQL]Introduce structure to hold...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3196
Thanks for the update @beyond1920!
PR is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100984668
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.stats
+
+/**
+ * column statistics
+ *
+ * @param ndv number of distinct values
+ * @param nullCount number of nulls
+ * @param avgLen average length of column values
+ * @param maxLen max length of column values
+ * @param max max value of column values
+ * @param min min value of column values
+ */
+case class ColumnStats(
+ ndv: Long,
+ nullCount: Long,
+ avgLen: Long,
+ maxLen: Long,
+ max: Option[Any],
+ min: Option[Any]) {
--- End diff --
Yes, I think you are right @beyond1920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100851572
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.stats
+
+/**
+ * column statistics
+ *
+ * @param ndv number of distinct values
+ * @param nullCount number of nulls
+ * @param avgLen average length of column values
+ * @param maxLen max length of column values
+ * @param max max value of column values
+ * @param min min value of column values
+ */
+case class ColumnStats(
+ ndv: Long,
--- End diff --
Make all stats optional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3196: [FLINK-5566] [Table API & SQL]Introduce structure to hold...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3196
Merged.
Thanks @beyond1920!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
Posted by beyond1920 <gi...@git.apache.org>.
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100950729
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.stats
+
+/**
+ * column statistics
+ *
+ * @param ndv number of distinct values
+ * @param nullCount number of nulls
+ * @param avgLen average length of column values
+ * @param maxLen max length of column values
+ * @param max max value of column values
+ * @param min min value of column values
+ */
+case class ColumnStats(
+ ndv: Long,
--- End diff --
@fhueske , there is no need to make all stats optional. If there is no statistics for ndv/nullcount/avgLen/maxLen, we could give them an invalid value, e.g, -1. But it does not work for max/min, because max/min value could be possible negative.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100851830
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.stats
+
+/**
+ * column statistics
+ *
+ * @param ndv number of distinct values
+ * @param nullCount number of nulls
+ * @param avgLen average length of column values
+ * @param maxLen max length of column values
+ * @param max max value of column values
+ * @param min min value of column values
+ */
+case class ColumnStats(
+ ndv: Long,
+ nullCount: Long,
+ avgLen: Long,
+ maxLen: Long,
+ max: Option[Any],
+ min: Option[Any]) {
--- End diff --
Does it make sense to denote whether stats are precise or approximate? Also an optional field could hold the a timestamp when the stats were generated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---