You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/30 18:44:59 UTC

[GitHub] [spark] allisonwang-db opened a new pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

allisonwang-db opened a new pull request #29915:
URL: https://github.com/apache/spark/pull/29915


   ### What changes were proposed in this pull request?
   This PR combines the current plan and the initial plan in the AQE query plan string when the two plans are the same. It also removes the `== Current Plan ==` and `== Initial Plan ==` headers:
   
   Before
   ```scala
   AdaptiveSparkPlan isFinalPlan=false
   +- == Current Plan ==
      SortMergeJoin [key#13], [a#23], Inner
      :- Sort [key#13 ASC NULLS FIRST], false, 0
      :  +- Exchange hashpartitioning(key#13, 5), true, [id=#94]
               ...
   +- == Initial Plan ==
      SortMergeJoin [key#13], [a#23], Inner
      :- Sort [key#13 ASC NULLS FIRST], false, 0
      :  +- Exchange hashpartitioning(key#13, 5), true, [id=#94]
               ...
   ```
   After
   ```scala
   AdaptiveSparkPlan isFinalPlan=false
   +- SortMergeJoin [key#13], [a#23], Inner
      :- Sort [key#13 ASC NULLS FIRST], false, 0
      :  +- Exchange hashpartitioning(key#13, 5), true, [id=#94]
               ...
   ```
   For SQL `EXPLAIN` output:
   Before
   ```scala
   AdaptiveSparkPlan (8)
   +- == Current Plan ==
      Sort (7)
      +- Exchange (6)
         ...
   +- == Initial Plan ==
      Sort (7)
      +- Exchange (6)
         ...
   ```
   After
   ```scala
   AdaptiveSparkPlan (8)
   +- Sort (7)
      +- Exchange (6)
         ...
   ```
   
   ### Why are the changes needed?
   To simplify the AQE plan string by removing the redundant plan information.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes.
   
   ### How was this patch tested?
   Modified the existing unit test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701606366






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gatorsmile commented on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-703744238


   Thanks! Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701714471






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701597920


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33900/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701714471






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gatorsmile closed pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
gatorsmile closed pull request #29915:
URL: https://github.com/apache/spark/pull/29915


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701606366






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701576801


   **[Test build #129284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129284/testReport)** for PR 29915 at commit [`fe4873e`](https://github.com/apache/spark/commit/fe4873eeb24e15184873c2cb65f204f37126bb14).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701713857


   **[Test build #129284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129284/testReport)** for PR 29915 at commit [`fe4873e`](https://github.com/apache/spark/commit/fe4873eeb24e15184873c2cb65f204f37126bb14).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701606339


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33900/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29915: [SPARK-33038][SQL] Combine AQE initial and current plan string when two plans are the same

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29915:
URL: https://github.com/apache/spark/pull/29915#issuecomment-701576801


   **[Test build #129284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129284/testReport)** for PR 29915 at commit [`fe4873e`](https://github.com/apache/spark/commit/fe4873eeb24e15184873c2cb65f204f37126bb14).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org