You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Chris Nauroth (JIRA)" <ji...@apache.org> on 2015/03/24 23:13:56 UTC

[jira] [Commented] (HADOOP-11745) Incorporate shellcheck static analysis into Jenkins pre-commit builds.

    [ https://issues.apache.org/jira/browse/HADOOP-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378767#comment-14378767 ] 

Chris Nauroth commented on HADOOP-11745:
----------------------------------------

Here is information on ShellCheck:

http://www.shellcheck.net/about.html

We'd need to arrange for this to be deployed to all of the Jenkins hosts and then modify test-patch.sh to call it.

cc [~aw]

> Incorporate shellcheck static analysis into Jenkins pre-commit builds.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-11745
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11745
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, scripts
>            Reporter: Chris Nauroth
>            Priority: Minor
>
> During the shell script rewrite on trunk, we've been using ShellCheck as a static analysis tool to catch common errors.  We can incorporate this directly into Jenkins pre-commit builds.  Jenkins can reply with a -1 on shell script patches that introduce new ShellCheck warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)