You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Josh McKenzie (Jira)" <ji...@apache.org> on 2022/05/11 15:54:00 UTC
[jira] [Comment Edited] (CASSANDRA-17593) StorageService read threshold get methods throw NullPointerException due to not handling null configs
[ https://issues.apache.org/jira/browse/CASSANDRA-17593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534987#comment-17534987 ]
Josh McKenzie edited comment on CASSANDRA-17593 at 5/11/22 3:53 PM:
--------------------------------------------------------------------
Only 1 new test failure on ASF infra that's not accounted for, and without digging into the code here or there I would assume they're unrelated (org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalDelete[1: clusterMinVersion=3.11]-compression)
[CI Results]
Branch: 4.1, build number: 12
butler url: [https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-4.1/Cassandra-4.1]
jenkins url: [https://ci-cassandra.apache.org/job/Cassandra-4.1/12/]
JIRA: CASSANDRA-17593
commit url: [https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=6396562f71316838083618714b142fd982ae0155]
affected paths:
* test/unit/org/apache/cassandra/cql3/CQLTester.java
* test/distributed/org/apache/cassandra/distributed/impl/Instance.java
* test/distributed/org/apache/cassandra/distributed/test/jmx/JMXGetterCheckTest.java
* src/java/org/apache/cassandra/locator/TokenMetadata.java
* src/java/org/apache/cassandra/config/DatabaseDescriptor.java
* src/java/org/apache/cassandra/service/StorageService.java
* CHANGES.txt
Build Result: UNSTABLE
Passing Tests: 48673
Failing Tests: 7
||Test|Failures|JIRA|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade_with_internode_ssl|1 of 10|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestProtoV3Upgrade*%22]|
|org.apache.cassandra.net.ProxyHandlerConnectionsTest.testExpireSome|3 of 10|CASSANDRA-17301?|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade|1 of 10|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestProtoV3Upgrade*%22]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_parallel_upgrade|2 of 10|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestProtoV3Upgrade*%22]|
|org.apache.cassandra.distributed.test.CASTest.testConflictingWritesWithStaleRingInformation|4 of 10|CASSANDRA-17461?|
|org.apache.cassandra.db.SinglePartitionSliceCommandTest.testPartitionDeletionRangeDeletionTie|5 of 10|CASSANDRA-17463?|
|org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalDelete[1: clusterMinVersion=3.11]-compression|1 of 10|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
was (Author: jmckenzie):
Only 1 new test on ASF infra that's not accounted for, and without digging into the code here or there I would assume they're unrelated (org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalDelete[1: clusterMinVersion=3.11]-compression)
[CI Results]
Branch: 4.1, build number: 12
butler url: [https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-4.1/Cassandra-4.1]
jenkins url: [https://ci-cassandra.apache.org/job/Cassandra-4.1/12/]
JIRA: CASSANDRA-17593
commit url: [https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=6396562f71316838083618714b142fd982ae0155]
affected paths:
* test/unit/org/apache/cassandra/cql3/CQLTester.java
* test/distributed/org/apache/cassandra/distributed/impl/Instance.java
* test/distributed/org/apache/cassandra/distributed/test/jmx/JMXGetterCheckTest.java
* src/java/org/apache/cassandra/locator/TokenMetadata.java
* src/java/org/apache/cassandra/config/DatabaseDescriptor.java
* src/java/org/apache/cassandra/service/StorageService.java
* CHANGES.txt
Build Result: UNSTABLE
Passing Tests: 48673
Failing Tests: 7
||Test|Failures|JIRA|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade_with_internode_ssl|1 of 10|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestProtoV3Upgrade*%22]|
|org.apache.cassandra.net.ProxyHandlerConnectionsTest.testExpireSome|3 of 10|CASSANDRA-17301?|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade|1 of 10|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestProtoV3Upgrade*%22]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_parallel_upgrade|2 of 10|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestProtoV3Upgrade*%22]|
|org.apache.cassandra.distributed.test.CASTest.testConflictingWritesWithStaleRingInformation|4 of 10|CASSANDRA-17461?|
|org.apache.cassandra.db.SinglePartitionSliceCommandTest.testPartitionDeletionRangeDeletionTie|5 of 10|CASSANDRA-17463?|
|org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalDelete[1: clusterMinVersion=3.11]-compression|1 of 10|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
> StorageService read threshold get methods throw NullPointerException due to not handling null configs
> -----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17593
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17593
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.1
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> org.apache.cassandra.service.StorageService#getCoordinatorLargeReadWarnThreshold and other similar get methods touch the following null configs
> {code}
> public volatile DataStorageSpec coordinator_read_size_warn_threshold = null;
> public volatile DataStorageSpec coordinator_read_size_fail_threshold = null;
> public volatile DataStorageSpec local_read_size_warn_threshold = null;
> public volatile DataStorageSpec local_read_size_fail_threshold = null;
> public volatile DataStorageSpec row_index_read_size_warn_threshold = null;
> public volatile DataStorageSpec row_index_read_size_fail_threshold = null
> {code}
> Null is a valid state for these configs, so null must be handled in the get methods; they currently are not and throw NullPointerException when accessed via JMX
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org