You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2011/05/12 08:39:50 UTC
[jira] [Created] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
-----------------------------------------------------------------------------------
Key: HDFS-1925
URL: https://issues.apache.org/jira/browse/HDFS-1925
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Konstantin Shvachko
Fix For: 0.22.0
{{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037350#comment-13037350 ]
Hudson commented on HDFS-1925:
------------------------------
Integrated in Hadoop-Hdfs-trunk #673 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/])
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Joey Echeverria
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035812#comment-13035812 ]
Hadoop QA commented on HDFS-1925:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479655/HDFS-1925-1.patch
against trunk revision 1124364.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
org.apache.hadoop.tools.TestJMXGet
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//console
This message is automatically generated.
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Joey Echeverria
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037309#comment-13037309 ]
Hudson commented on HDFS-1925:
------------------------------
Integrated in Hadoop-Hdfs-22-branch #53 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/53/])
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Joey Echeverria
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-1925:
---------------------------------
Labels: newbie (was: )
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Labels: newbie
> Fix For: 0.22.0
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria reassigned HDFS-1925:
-------------------------------------
Assignee: Joey Echeverria
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Joey Echeverria
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035800#comment-13035800 ]
Todd Lipcon commented on HDFS-1925:
-----------------------------------
I'm impressed by the valiant effort to make a regression test, but I think the test itself is too fragile for what's essentially a code cleanup. +1 on the fix but -1 on the test :) Assuming the test-patch comes back clean I'll commit just the fix part.
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Joey Echeverria
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1925:
----------------------------------
Attachment: HDFS-1925-1.patch
Here's my first official patch!
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035515#comment-13035515 ]
Joey Echeverria commented on HDFS-1925:
---------------------------------------
If no one else is working on this, I'll take a stab at it.
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Labels: newbie
> Fix For: 0.22.0
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1925:
----------------------------------
Status: Patch Available (was: Open)
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037197#comment-13037197 ]
Hudson commented on HDFS-1925:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #677 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/677/])
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Joey Echeverria
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1925) SafeModeInfo should use
DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-1925:
------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to 22 and trunk. Thanks, Joey
> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1925
> URL: https://issues.apache.org/jira/browse/HDFS-1925
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Joey Echeverria
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to 0.999f.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira