You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/08/26 11:21:47 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #4417: arch/esp32: Properly handle GPIO interrupt in SMP.
Ouss4 opened a new pull request #4417:
URL: https://github.com/apache/incubator-nuttx/pull/4417
## Summary
The PRO CPU and APP CPU have different peripherals for GPIO interrupts.
Each CPU needs to allocate an interrupt and attach it to its GPIO peripheral.
## Impact
ESP32's GPIO in SMP.
## Testing
esp32-wrover-kit:gpio with necessary configs to enable SMP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4417: arch/esp32: Properly handle GPIO interrupt in SMP.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4417:
URL: https://github.com/apache/incubator-nuttx/pull/4417#discussion_r696598550
##########
File path: arch/xtensa/include/esp32/irq.h
##########
@@ -409,6 +424,24 @@
* Inline functions
****************************************************************************/
+#ifdef CONFIG_ESP32_GPIO_IRQ
+#ifdef CONFIG_SMP
+static inline esp32_irq_gpio(int cpu)
Review comment:
```suggestion
static inline int esp32_irq_gpio(int cpu)
```
Missing return type.
Acceptable in C90, but forbidden from C99 onwards.
##########
File path: arch/xtensa/include/esp32/irq.h
##########
@@ -409,6 +424,24 @@
* Inline functions
****************************************************************************/
+#ifdef CONFIG_ESP32_GPIO_IRQ
+#ifdef CONFIG_SMP
+static inline esp32_irq_gpio(int cpu)
+{
+ if (cpu == 0)
+ {
+ return ESP32_IRQ_CPU_GPIO;
+ }
+ else
+ {
+ return ESP32_IRQ_APPCPU_GPIO;
Review comment:
```suggestion
return ESP32_IRQ_APPCPU_GPIO;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4417: arch/esp32: Properly handle GPIO interrupt in SMP.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4417:
URL: https://github.com/apache/incubator-nuttx/pull/4417#discussion_r696661093
##########
File path: arch/xtensa/include/esp32/irq.h
##########
@@ -409,6 +424,24 @@
* Inline functions
****************************************************************************/
+#ifdef CONFIG_ESP32_GPIO_IRQ
+#ifdef CONFIG_SMP
+static inline esp32_irq_gpio(int cpu)
+{
+ if (cpu == 0)
+ {
+ return ESP32_IRQ_CPU_GPIO;
+ }
+ else
+ {
+ return ESP32_IRQ_APPCPU_GPIO;
Review comment:
Fixed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #4417: arch/esp32: Properly handle GPIO interrupt in SMP.
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #4417:
URL: https://github.com/apache/incubator-nuttx/pull/4417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4417: arch/esp32: Properly handle GPIO interrupt in SMP.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4417:
URL: https://github.com/apache/incubator-nuttx/pull/4417#discussion_r696661302
##########
File path: arch/xtensa/include/esp32/irq.h
##########
@@ -409,6 +424,24 @@
* Inline functions
****************************************************************************/
+#ifdef CONFIG_ESP32_GPIO_IRQ
+#ifdef CONFIG_SMP
+static inline esp32_irq_gpio(int cpu)
Review comment:
Thanks for catching this! Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org