[jira] [Commented] (TAP5-2118) Certain package naming patterns result in incorrect logical names for pages

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111640#comment-14111640 ] 

Howard M. Lewis Ship commented on TAP5-2118:
--------------------------------------------

It comes down to the order in which the package names are applied.

I'm concerned that reversing the order ("exports", which is deeper, first) may cause subtle issues.

A patch with tests will be reviewed; note that there was a code change today (26 Aug 2014).

> Certain package naming patterns result in incorrect logical names for pages
> ---------------------------------------------------------------------------
>
>                 Key: TAP5-2118
>                 URL: https://issues.apache.org/jira/browse/TAP5-2118
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.6
>            Reporter: Thilo Tanner
>
> There is a small bug in ComponentClassResolverImpl in the method toLogicalName.
> Consider the following page: pages.export.exports.ExportsIndex
> This page will be mapped to:
> export/exports/sIndex instead of export/exports
> It seems that stripTerm is invoked with export instead of exports.
> I can contribute a patch if you like. Please let me know.
> Thanks and kind regards,
> Thilo



--
This message was sent by Atlassian JIRA
(v6.2#6252)