[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5240: GEODE-8242: Add HSTRLEN redis command

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #5240:
URL: https://github.com/apache/geode/pull/5240#discussion_r438972373



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/HashesIntegrationTest.java
##########
@@ -150,6 +150,15 @@ public void testHDelDeletesKeyWhenHashIsEmpty() {
     assertThat(jedis.exists("farm")).isFalse();
   }
 
+  @Test
+  public void testHStrLen() {
+    jedis.hset("farm", "chicken", "little");
+
+    assertThat(jedis.hstrlen("farm", "chicken")).isEqualTo("little".length());
+    assertThat(jedis.hstrlen("farm", "unknown-field")).isEqualTo(0);
+    assertThat(jedis.hstrlen("unknown-key", "unknown-field")).isEqualTo(0);
+  }

Review comment:
       do a hstrlen on some other existing type (like a string or set) and confirm you get the expected error

##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/HashesIntegrationTest.java
##########
@@ -150,6 +150,15 @@ public void testHDelDeletesKeyWhenHashIsEmpty() {
     assertThat(jedis.exists("farm")).isFalse();
   }
 
+  @Test
+  public void testHStrLen() {
+    jedis.hset("farm", "chicken", "little");
+
+    assertThat(jedis.hstrlen("farm", "chicken")).isEqualTo("little".length());
+    assertThat(jedis.hstrlen("farm", "unknown-field")).isEqualTo(0);
+    assertThat(jedis.hstrlen("unknown-key", "unknown-field")).isEqualTo(0);
+  }

Review comment:
       do we have a way of testing the wrong number of arguments to a command? Will any of our redis clients even let that happen?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org