You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhangshenghang (via GitHub)" <gi...@apache.org> on 2026/07/02 00:16:20 UTC

[PR] [Fix][Zeta] Make finished jobs API tolerate missing history data [seatunnel]

zhangshenghang opened a new pull request, #11269:
URL: https://github.com/apache/seatunnel/pull/11269

   ### Purpose
   
   Fixes #10039.
   
   The finished-jobs REST endpoint could fail the whole response when historical job data loaded from the persisted maps was incomplete or partially unavailable. In practice, this can happen with external map storage such as S3, where one missing metrics/DAG record or a null finish time should not make the UI receive a null/500 response for the whole page.
   
   ### Changes
   
   - Sort finished jobs with null finish times placed last instead of throwing during comparison.
   - Load finished-job metrics and DAG data defensively; if one record is missing or cannot be read, return that job with empty metrics/DAG instead of failing the entire list.
   - Add a regression test for finished-job listing with missing finish time, unavailable metrics, and unavailable DAG data.
   
   ### Tests
   
   - `./mvnw spotless:apply`
   - `./mvnw -pl seatunnel-engine/seatunnel-engine-server -DskipIT -Dcheckstyle.skip -Dlicense.skip=true -Dspotless.check.skip=true -Dtest=JobInfoServiceNullSafetyTest test`
   - `./mvnw -q -DskipTests verify`
   - `git diff --check`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Zeta] Make finished jobs API tolerate missing history data [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11269:
URL: https://github.com/apache/seatunnel/pull/11269


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Zeta] Make finished jobs API tolerate missing history data [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11269:
URL: https://github.com/apache/seatunnel/pull/11269#issuecomment-4880662199

   Rechecked the latest head and the current merge gate on this PR.
   
   ## Current state
   - The finished-jobs hardening path still looks good to me on the latest head.
   - The current `Build` check is now green.
   - I do not see a new source-side blocker from Daniel's side.
   
   So from the Daniel technical-review side, this is no longer waiting on a CI gate. Since I only have read-level review controls here, a write-capable maintainer may still need to handle the final approval / merge action in GitHub if the review summary still shows older state elsewhere.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org