You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2011/05/23 18:50:04 UTC
svn commit: r1126578 [4/4] - in /lucene/dev/branches/flexscoring: ./
dev-tools/eclipse/ dev-tools/idea/ dev-tools/idea/.idea/
dev-tools/idea/lucene/ dev-tools/idea/lucene/contrib/ant/
dev-tools/idea/lucene/contrib/db/bdb-je/ dev-tools/idea/lucene/contr...
Modified: lucene/dev/branches/flexscoring/solr/src/test/org/apache/solr/client/solrj/embedded/TestSolrProperties.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/flexscoring/solr/src/test/org/apache/solr/client/solrj/embedded/TestSolrProperties.java?rev=1126578&r1=1126577&r2=1126578&view=diff
==============================================================================
--- lucene/dev/branches/flexscoring/solr/src/test/org/apache/solr/client/solrj/embedded/TestSolrProperties.java (original)
+++ lucene/dev/branches/flexscoring/solr/src/test/org/apache/solr/client/solrj/embedded/TestSolrProperties.java Mon May 23 16:49:59 2011
@@ -37,6 +37,7 @@ import org.apache.solr.client.solrj.requ
import org.apache.solr.client.solrj.request.UpdateRequest.ACTION;
import org.apache.solr.client.solrj.response.CoreAdminResponse;
import org.apache.solr.common.SolrInputDocument;
+import org.apache.solr.common.util.FileUtils;
import org.apache.solr.core.CoreContainer;
import org.apache.solr.util.AbstractSolrTestCase;
import org.junit.After;
@@ -54,6 +55,7 @@ import org.w3c.dom.Node;
public class TestSolrProperties extends LuceneTestCase {
protected static Logger log = LoggerFactory.getLogger(TestSolrProperties.class);
protected CoreContainer cores = null;
+ private File home;
private File solrXml;
private static final XPathFactory xpathFactory = XPathFactory.newInstance();
@@ -62,21 +64,27 @@ public class TestSolrProperties extends
return "solr/shared";
}
- public String getSolrXml() {
+ public String getOrigSolrXml() {
return "solr.xml";
}
+ public String getSolrXml() {
+ return "test-solr.xml";
+ }
+
@Override
@Before
public void setUp() throws Exception {
super.setUp();
System.setProperty("solr.solr.home", getSolrHome());
- File home = SolrTestCaseJ4.getFile(getSolrHome());
+ home = SolrTestCaseJ4.getFile(getSolrHome());
System.setProperty("solr.solr.home", home.getAbsolutePath());
log.info("pwd: " + (new File(".")).getAbsolutePath());
+ File origSolrXml = new File(home, getOrigSolrXml());
solrXml = new File(home, getSolrXml());
+ FileUtils.copyFile(origSolrXml, solrXml);
cores = new CoreContainer(home.getAbsolutePath(), solrXml);
}
@@ -85,7 +93,7 @@ public class TestSolrProperties extends
public void tearDown() throws Exception {
if (cores != null)
cores.shutdown();
- File dataDir = new File(getSolrHome() + "/data");
+ File dataDir = new File(home,"data");
String skip = System.getProperty("solr.test.leavedatadir");
if (null != skip && 0 != skip.trim().length()) {
log.info("NOTE: per solr.test.leavedatadir, dataDir will not be removed: " + dataDir.getAbsolutePath());
@@ -94,8 +102,9 @@ public class TestSolrProperties extends
log.warn("!!!! WARNING: best effort to remove " + dataDir.getAbsolutePath() + " FAILED !!!!!");
}
}
- File persistedFile = new File(getSolrHome() + File.separator + "solr-persist.xml");
- persistedFile.delete();
+ File persistedFile = new File(home,"solr-persist.xml");
+ assertTrue("Failed to delete "+persistedFile, persistedFile.delete());
+ assertTrue("Failed to delete "+solrXml, solrXml.delete());
super.tearDown();
}
Modified: lucene/dev/branches/flexscoring/solr/src/test/org/apache/solr/request/JSONWriterTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/flexscoring/solr/src/test/org/apache/solr/request/JSONWriterTest.java?rev=1126578&r1=1126577&r2=1126578&view=diff
==============================================================================
--- lucene/dev/branches/flexscoring/solr/src/test/org/apache/solr/request/JSONWriterTest.java (original)
+++ lucene/dev/branches/flexscoring/solr/src/test/org/apache/solr/request/JSONWriterTest.java Mon May 23 16:49:59 2011
@@ -73,12 +73,12 @@ public class JSONWriterTest extends Solr
StringWriter buf = new StringWriter();
NamedList nl = new NamedList();
- nl.add("data1", "hello");
+ nl.add("data1", "he\u2028llo\u2029!"); // make sure that 2028 and 2029 are both escaped (they are illegal in javascript)
nl.add(null, 42);
rsp.add("nl", nl);
w.write(buf, req, rsp);
- assertEquals(buf.toString(), "{\"nl\":[[\"data1\",\"hello\"],[null,42]]}");
+ assertEquals("{\"nl\":[[\"data1\",\"he\\u2028llo\\u2029!\"],[null,42]]}", buf.toString());
req.close();
}